Skip to content

Commit

Permalink
[code-review] gf conditions: get tagging data from 2nd sheet
Browse files Browse the repository at this point in the history
com.google.fonts/check/metadata/has_tags
On the Google Fonts profile

Also fetch family tagging data from a second Google Sheet (Submissions from designers via form: https://forms.gle/jcp3nDv63LaV1rxH6)

(PR #4576)
  • Loading branch information
felipesanches committed Mar 4, 2024
1 parent 82cb1eb commit 13028f2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 4 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,16 @@ Below are the noteworthy changes from each release.
A more detailed list of changes is available in the corresponding milestones for each release in the Github issue tracker (https://github.com/googlefonts/fontbakery/milestones?state=closed).


## Upcoming release: 0.12.0 (2024-Feb-??)
## Upcoming release: 0.12.0 (2024-Mar-??)
- Documentation for profile and check writers has been rewritten.
- And also includes the changes from the previous release-candidates:
- v0.12.0a1 (2024-Feb-14)
- v0.12.0a2 (2024-Feb-21)
- In the googlefonts profile, get family tagging data from another Google Sheet

### Changes to existing checks
#### On the Google Fonts profile
- **[com.google.fonts/check/metadata/has_tags]:** Also fetch family tagging data from a second Google Sheet (Submissions from designers via form: https://forms.gle/jcp3nDv63LaV1rxH6) (PR #4576)

#### On the Universal profile
- **DISABLED - [com.google.fonts/check/legacy_accents]:** This is one of the checks that we probably should run on the sources instead of binaries. (https://github.com/fonttools/fontbakery/issues/3959#issuecomment-1822913547)

Expand Down
2 changes: 2 additions & 0 deletions Lib/fontbakery/checks/googlefonts/metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -1539,6 +1539,8 @@ def com_google_fonts_check_metadata_empty_designer(family_metadata):
conditions=["network"],
rationale="""
Any font published on Google Fonts must be listed in the tags spreadsheet.
https://forms.gle/jcp3nDv63LaV1rxH6
""",
proposal="https://github.com/fonttools/fontbakery/issues/4465",
)
Expand Down

0 comments on commit 13028f2

Please sign in to comment.