splitting out checks into individual files

fonttools · Nov 22, 2024 · 2a5225f · 2a5225f
1 parent c995480
commit 2a5225f
Show file tree

Hide file tree

Showing 155 changed files with 1,768 additions and 1,671 deletions.
diff --git a/Lib/fontbakery/checks/cmap/__init__.py b/Lib/fontbakery/checks/cmap/__init__.py
diff --git a/Lib/fontbakery/checks/cmap_format_12.py → Lib/fontbakery/checks/cmap/format_12.py b/Lib/fontbakery/checks/cmap_format_12.py → Lib/fontbakery/checks/cmap/format_12.py
diff --git a/Lib/fontbakery/checks/family/__init__.py b/Lib/fontbakery/checks/family/__init__.py
diff --git a/...tbakery/checks/family_single_directory.py → ...tbakery/checks/family/single_directory.py b/...tbakery/checks/family_single_directory.py → ...tbakery/checks/family/single_directory.py
diff --git a/...tbakery/checks/family_vertical_metrics.py → ...tbakery/checks/family/vertical_metrics.py b/...tbakery/checks/family_vertical_metrics.py → ...tbakery/checks/family/vertical_metrics.py
diff --git a/...y/checks/family_win_ascent_and_descent.py → ...y/checks/family/win_ascent_and_descent.py b/...y/checks/family_win_ascent_and_descent.py → ...y/checks/family/win_ascent_and_descent.py
diff --git a/Lib/fontbakery/checks/filesize.py → Lib/fontbakery/checks/file_size.py b/Lib/fontbakery/checks/filesize.py → Lib/fontbakery/checks/file_size.py
diff --git a/Lib/fontbakery/checks/fontbakery.py → Lib/fontbakery/checks/fontbakery_version.py b/Lib/fontbakery/checks/fontbakery.py → Lib/fontbakery/checks/fontbakery_version.py
diff --git a/Lib/fontbakery/checks/namecheck.py → Lib/fontbakery/checks/fontdata_namecheck.py b/Lib/fontbakery/checks/namecheck.py → Lib/fontbakery/checks/fontdata_namecheck.py
diff --git a/Lib/fontbakery/checks/fontval.py → Lib/fontbakery/checks/fontvalidator.py b/Lib/fontbakery/checks/fontval.py → Lib/fontbakery/checks/fontvalidator.py
diff --git a/Lib/fontbakery/checks/glyphs_file/__init__.py b/Lib/fontbakery/checks/glyphs_file/__init__.py
diff --git a/Lib/fontbakery/checks/glyphs_file/name/__init__.py b/Lib/fontbakery/checks/glyphs_file/name/__init__.py
diff --git a/..._file_name_family_and_style_max_length.py → ..._file/name/family_and_style_max_length.py b/..._file_name_family_and_style_max_length.py → ..._file/name/family_and_style_max_length.py
diff --git a/...ecks/inconsistencies_between_fvar_stat.py → ...ecks/inconsistencies_between_fvar_STAT.py b/...ecks/inconsistencies_between_fvar_stat.py → ...ecks/inconsistencies_between_fvar_STAT.py
@@ -1,55 +1,55 @@
 from fontbakery.prelude import FAIL, Message, check
 
 
-def is_covered_in_stat(ttFont, axis_tag, value):
+def is_covered_in_STAT(ttFont, axis_tag, value):
     if "STAT" not in ttFont:
         return False
-    stat_table = ttFont["STAT"].table
-    if stat_table.AxisValueCount == 0:
+    STAT_table = ttFont["STAT"].table
+    if STAT_table.AxisValueCount == 0:
         return False
-    for ax_value in stat_table.AxisValueArray.AxisValue:
+    for ax_value in STAT_table.AxisValueArray.AxisValue:
         ax_value_format = ax_value.Format
-        stat_value = []
+        STAT_value = []
         if ax_value_format in (1, 2, 3):
-            axis_tag_stat = stat_table.DesignAxisRecord.Axis[ax_value.AxisIndex].AxisTag
-            if axis_tag != axis_tag_stat:
+            axis_tag_STAT = STAT_table.DesignAxisRecord.Axis[ax_value.AxisIndex].AxisTag
+            if axis_tag != axis_tag_STAT:
                 continue
 
             if ax_value_format in (1, 3):
-                stat_value.append(ax_value.Value)
+                STAT_value.append(ax_value.Value)
 
             if ax_value_format == 3:
-                stat_value.append(ax_value.LinkedValue)
+                STAT_value.append(ax_value.LinkedValue)
 
             if ax_value_format == 2:
-                stat_value.append(ax_value.NominalValue)
+                STAT_value.append(ax_value.NominalValue)
 
         if ax_value_format == 4:
             # TODO: Need to implement
             #  locations check as well
             pass
 
-        if value in stat_value:
+        if value in STAT_value:
             return True
 
     return False
 
 
 @check(
-    id="inconsistencies_between_fvar_stat",
+    id="inconsistencies_between_fvar_STAT",
     rationale="""
         Check for inconsistencies in names and values between the fvar instances
         and STAT table. Inconsistencies may cause issues in apps like Adobe InDesign.
     """,
     conditions=["is_variable_font"],
     proposal="https://github.com/fonttools/fontbakery/pull/3636",
 )
-def check_inconsistencies_between_fvar_stat(ttFont):
+def check_inconsistencies_between_fvar_STAT(ttFont):
     """Checking if STAT entries matches fvar and vice versa."""
 
     if "STAT" not in ttFont:
         return FAIL, Message(
-            "missing-stat-table", "Missing STAT table in variable font."
+            "missing-STAT-table", "Missing STAT table in variable font."
         )
     fvar = ttFont["fvar"]
     name = ttFont["name"]
@@ -65,7 +65,7 @@ def check_inconsistencies_between_fvar_stat(ttFont):
             continue
 
         for axis_tag, value in ins.coordinates.items():
-            if not is_covered_in_stat(ttFont, axis_tag, value):
+            if not is_covered_in_STAT(ttFont, axis_tag, value):
                 yield FAIL, Message(
                     "missing-fvar-instance-axis-value",
                     f"{instance_name}: '{axis_tag}' axis value '{value}'"