Skip to content

Commit

Permalink
Add rationale for OS/2.fsSelection check
Browse files Browse the repository at this point in the history
com.google.fonts/check/fsselection
On the Open Type Profile.

(PR #4570)
  • Loading branch information
simoncozens authored and felipesanches committed Mar 5, 2024
1 parent f06e09a commit 420d0b4
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ A more detailed list of changes is available in the corresponding milestones for
- **[com.google.fonts/check/family/panose_familytype]:** Add rationale and improve message when there are inconsistencies. (PR #4570)
- **[com.google.fonts/check/xavgcharwidth]:** Added rationale. Also, when glyphs needed to compute xAvgCharWidth are missing, it is considered critical, so it is now results in a FATAL-level result. (PR #4570)
- **[com.adobe.fonts/check/fsselection_matches_macstyle]:** Improve log messages to include the bit values. (PR #4570)
- **[com.google.fonts/check/fsselection]:** Added rationale. (PR #4570)


## 0.12.0a2 (2024-Feb-21)
Expand Down
10 changes: 10 additions & 0 deletions Lib/fontbakery/checks/opentype/os2.py
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,16 @@ def com_thetypefounders_check_vendor_id(config, ttFont):
id="com.google.fonts/check/fsselection",
conditions=["style"],
proposal="legacy:check/129",
rationale="""
The OS/2.fsSelection field is a bit field used to specify the stylistic
qualities of the font - in particular, it specifies to some operating
systems whether the font is italic (bit 0), bold (bit 5) or regular
(bit 6).
This check verifies that the fsSelection field is set correctly for the
font style. For a family of static fonts created in GlyphsApp, this is
set by using the style linking checkboxes in the exports settings.
""",
)
def com_google_fonts_check_fsselection(ttFont, style):
"""Checking OS/2 fsSelection value."""
Expand Down

0 comments on commit 420d0b4

Please sign in to comment.