Skip to content

Commit

Permalink
Add rationale for has_ttfautohint_params
Browse files Browse the repository at this point in the history
com.google.fonts/check/has_ttfautohint_params
On the Google Fonts Profile.

(PR #4570)
  • Loading branch information
simoncozens authored and felipesanches committed Mar 5, 2024
1 parent e67a869 commit 5f280ab
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ A more detailed list of changes is available in the corresponding milestones for
- **[com.google.fonts/check/metadata/canonical_weight_value]:** Added rationale. (PR #4570)
- **[com.google.fonts/check/metadata/copyright_max_length]:** Added rationale. (PR #4570)
- **[com.google.fonts/check/metadata/nameid/copyright]:** Added rationale. (PR #4570)
- **[com.google.fonts/check/has_ttfautohint_params]:** Added rationale. (PR #4570)

#### On the FontValidator profile
- **[com.google.fonts/check/fontvalidator]:** Added rationale. (PR #4570)
Expand Down
6 changes: 6 additions & 0 deletions Lib/fontbakery/checks/googlefonts/hinting.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,12 @@ def com_google_fonts_check_hinting_impact(font):
@check(
id="com.google.fonts/check/has_ttfautohint_params",
proposal="https://github.com/fonttools/fontbakery/issues/1773",
rationale="""
It is critically important that all static TTFs in the API which
were autohinted with ttfautohint store their TTFAutohint args in
the 'name' table, so that an automated solution can be made to
replicate the hinting on subsets, etc.
""",
)
def com_google_fonts_check_has_ttfautohint_params(ttFont):
"""Font has ttfautohint params?"""
Expand Down

0 comments on commit 5f280ab

Please sign in to comment.