Skip to content

Commit

Permalink
Add rationale for metadata/license
Browse files Browse the repository at this point in the history
com.google.fonts/check/metadata/license
On the Google Fonts Profile.

(PR #4570)
  • Loading branch information
simoncozens authored and felipesanches committed Mar 5, 2024
1 parent 51856ab commit ac87f85
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ A more detailed list of changes is available in the corresponding milestones for
- **[com.google.fonts/check/production_glyphs_similarity]:** Added rationale. (PR #4570)
- **[com.google.fonts/check/version_bump]:** Added rationale. (PR #4570)
- **[com.google.fonts/check/family/has_license]:** Added rationale. (PR #4570)
- **[com.google.fonts/check/metadata/license]:** Added rationale. (PR #4570)

#### On the FontValidator profile
- **[com.google.fonts/check/fontvalidator]:** Added rationale. (PR #4570)
Expand Down
5 changes: 5 additions & 0 deletions Lib/fontbakery/checks/googlefonts/license.py
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,11 @@ def com_google_fonts_check_name_license_url(ttFont, familyname):
id="com.google.fonts/check/metadata/license",
conditions=["family_metadata"],
proposal="legacy:check/085",
rationale="""
The license field in METADATA.pb must contain one of the
three values "APACHE2", "UFL" or "OFL". (New fonts should
generally be OFL unless there are special circumstances.)
""",
)
def com_google_fonts_check_metadata_license(family_metadata):
"""METADATA.pb license is "APACHE2", "UFL" or "OFL"?"""
Expand Down

0 comments on commit ac87f85

Please sign in to comment.