Add new checks for languagesystem DFLT dflt in UFO sources. #4247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramstein
commented
Aug 31, 2023
| yield PASS, "Default languagesystem inserted by compiler." | ||
| else: | ||
| tags = re.findall( | ||
| # pylint: disable-next=line-too-long |
There was a problem hiding this comment.
I tried a couple of different variations to keep the line shorter, but they all became harder to read/understand. Happy to change if anyone has suggestions...
bramstein
force-pushed
the
bs-ufo-default-languagesystem
branch
from
34d3a94 to
e6729b6
Compare
bramstein
force-pushed
the
bs-ufo-default-languagesystem
branch
from
e6729b6 to
cbe1063
Compare
|
thanks, @bramstein |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new check that tests for the presence of a
languagesystem DFLT dfltstatement in UFO feature files. If a feature file contains nolanguagesystemstatements the compiler will automatically insert one, but will not do so if there is anotherlanguagesystemstatement present (which may or not be theDFLT dflt). Warn in this case as it may lead to unexpected side effects (such as OT features not working for the default language).Fixes #4011
Checklist
CHANGELOG.md