Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

for_each flag_set #114

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

for_each flag_set #114

wants to merge 1 commit into from

Conversation

Neargye
Copy link

@Neargye Neargye commented Jun 23, 2020

Draft to fix #100

@Neargye
Copy link
Author

Neargye commented Jun 27, 2020

for_each was made by a method, not a free function. I'm not sure what's best.

It is possible to make functions begin()/end(), but to do this will have to create a class reference and iterator like for vector<bool>.

@foonathan
Copy link
Owner

Sorry for the delay, I'm busy with university stuff at the moment.

I think I prefer a begin()/end() interface with a proxy over the single function with callback. Would you be willing to try something like that out as well?

@Neargye
Copy link
Author

Neargye commented Jul 17, 2020

Thank you for your feedback.

Yes, I will try to make a solution with begin()/end().
I'll update this PR when I have something to show.

Base automatically changed from master to main February 13, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flag_set iterator(s) and/or for_each(flag_set<E>, [](E){})
2 participants
@Neargye @foonathan