Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lwc & aura language server available to be run from an executable file #580

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

WuggyX2
Copy link
Contributor

@WuggyX2 WuggyX2 commented Oct 11, 2023

What does this PR do?

This PR creates executable files and defines the bin property in package.json for both lwc language server and aura language server.

#581

What issues does this PR fix or reference?

This allows the language servers to be run using a terminal command, which in return allows editors like neovim to integrate with language servers using stdio. Neovim LSP DOC

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @WuggyX2 to sign the Salesforce Inc. Contributor License Agreement.

@gbockus-sf
Copy link
Contributor

@WuggyX2 Have you attempted to take care of the salesforce-cla step above?

@WuggyX2
Copy link
Contributor Author

WuggyX2 commented Oct 17, 2023

@gbockus-sf I tried, but it gave me an error, maybe because I used a different email than what is linked to this account. When I try to sign it again, the page say i have already signed it.

kuva

@gbockus-sf
Copy link
Contributor

@WuggyX2 Thanks for the follow up. The check is passing now so you're good to go. I'm just running this my our PM for awareness and it should be good to go I think.

Copy link
Contributor

@gbockus-sf gbockus-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WuggyX2 merging!

@gbockus-sf gbockus-sf merged commit dac89fb into forcedotcom:main Oct 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants