Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to node 18 #585

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

CristiCanizales
Copy link
Contributor

@CristiCanizales CristiCanizales commented Nov 24, 2023

What does this PR do?

Upgrade the version of node to Node 18.

What issues does this PR fix or reference?

@W-14196500@

@CristiCanizales CristiCanizales requested a review from a team as a code owner November 24, 2023 02:55
@CristiCanizales CristiCanizales self-assigned this Nov 24, 2023
@@ -7,15 +7,15 @@
"url": "https://github.com/forcedotcom/lightning-language-server.git"
},
"engines": {
"node": ">=16.0.0"
"node": ">=18.11.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 18.11.0?

@CristiCanizales CristiCanizales merged commit 4d5f3eb into main Nov 28, 2023
12 checks passed
@CristiCanizales CristiCanizales deleted the cristi/W-14196500/node-18 branch November 28, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants