feat: add tsconfig and .ts file extensions to .forceignore
#590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmsjtu
commented
Jun 26, 2024
Comment on lines
200
to
+204
| const forceignoreContent = fs.readFileSync(forceignorePath, 'utf8'); | ||
| expect(forceignoreContent).toContain('**/jsconfig.json'); | ||
| expect(forceignoreContent).toContain('**/tsconfig.json'); | ||
| expect(forceignoreContent).toContain('**/.eslintrc.json'); | ||
| expect(forceignoreContent).toContain('**/*.ts'); |
There was a problem hiding this comment.
I've also manually verified this works in a sfdx workspace by running the following sf cli command:
sf project list ignored --source-dir force-app/main/default
Which results in the following:
Found the following ignored files:
...
force-app/main/default/lwc/test/test.ts
force-app/main/default/lwc/tsconfig.json
daphne-sfdc
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Approved! 🎉
Test plan here: https://salesforce.quip.com/sDj1A1hsPBXT ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds
tsconfig.jsonand.tsfile extensions to the.forceignorefile.What issues does this PR fix or reference?
@W-15577958@