Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade min node engine to 18 #570

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Conversation

peternhale
Copy link
Contributor

What does this PR do?

Upgrades minimum node engine to 18
Bumps typescript from 4 to 5
Bumps a number of other dependencies w/o introducing breaking changes

What issues does this PR fix or reference?

@W-14196509@

@peternhale peternhale changed the title Phale/w 14196509 to node 18 fix: upgrade min node engine to 18 Nov 10, 2023
package.json Show resolved Hide resolved
@peternhale peternhale requested a review from smithgp November 15, 2023 16:28
Copy link
Contributor

@daphne-sfdc daphne-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CLI Integration and Apex extensions are both working as expected after this Node 18 upgrade. PR approved! ✅

QE doc here: https://salesforce.quip.com/HIO6AnnVbN1l

@peternhale peternhale merged commit 6c4a8c2 into main Nov 15, 2023
6 of 7 checks passed
@peternhale peternhale deleted the phale/W-14196509-to-node-18 branch November 15, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants