Revert to eslint 8 - for now #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristiand391
approved these changes
Oct 18, 2024
| @@ -22,7 +22,7 @@ | |||
| "@salesforce/eslint-plugin-aura": "^2.0.0", | |||
| "@salesforce/eslint-plugin-lightning": "^1.0.0", | |||
| "@salesforce/sfdx-lwc-jest": "^5.1.0", | |||
| "eslint": "^9.9.1", | |||
| "eslint": "^8.57.0", | |||
There was a problem hiding this comment.
@iowillhoit is there a reason 8.57.0 was chosen? 8.57.1 is last eslint v8 release published on Sep. 16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Dependabot bumped
eslintfrom 8 to 9. Version 9 is not supported by a number of repos that are not owned by the CLI team. It will take a coordinated effort to bring all of these up to date with eslint version 9.This reverts back to version 8 and also sets dependabot to ignore major version bumps.
Testing
yarn compileyarn linkcdtoplugin-templatesyarn link "@salesforce/templates"yarn compilebin/run.js project generate --output-dir tmp --name foocd tmp/foonpm installWhat issues does this PR fix or reference?
This work:
@W-17005525@
forcedotcom/cli#3065
Future work:
@W-16958727@
Related:
forcedotcom/cli#3056
forcedotcom/cli#3042
forcedotcom/cli#2986