Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add sfdx-project.json E2E test to Core End to End Tests #5680

Merged
merged 8 commits into from
Aug 6, 2024

Conversation

mingxuanzhangsfdx
Copy link
Member

The test is based on ESM.

What does this PR do?

This PR add a new test to make sure extensions are loaded properly with specific settings in sfdx-project.json.

What issues does this PR fix or reference?

@W-16114122@

Functionality Before

no such a test

Functionality After

The test can be run

@daphne-sfdc daphne-sfdc changed the title Mz/sfdx project.json chore: add sfdx-project.json E2E test to Core End to End Tests Aug 6, 2024
@daphne-sfdc daphne-sfdc marked this pull request as ready for review August 6, 2024 14:11
@daphne-sfdc daphne-sfdc requested a review from a team as a code owner August 6, 2024 14:11
@daphne-sfdc daphne-sfdc requested a review from smarvez August 6, 2024 14:11
Copy link
Contributor

@daphne-sfdc daphne-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🎉

Passing E2E test run on ESM using VSCode version stable: https://github.com/forcedotcom/salesforcedx-vscode/actions/runs/10268057507

@mingxuanzhangsfdx mingxuanzhangsfdx merged commit 4133b8f into develop Aug 6, 2024
25 checks passed
@mingxuanzhangsfdx mingxuanzhangsfdx deleted the mz/sfdx-project.json branch August 6, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants