FIX (Extension) @W-15639920@ address review feedback

forcedotcom · Sep 5, 2024 · 1bd5a1f · 1bd5a1f
1 parent 1ab7f49
commit 1bd5a1f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/src/commands/scanner/run/dfa.ts b/src/commands/scanner/run/dfa.ts
@@ -73,12 +73,14 @@ export default class Dfa extends ScannerRunCommand {
 		'enablecaching': Flags.boolean({
 			summary: '',
 			description: '',
-			env: 'SFGE_ENABLE_CACHING'
+			env: 'SFGE_ENABLE_CACHING',
+			hidden: true
 		}),
 		'cachepath': Flags.string({
 			summary: '',
 			description: '',
-			env: 'SFGE_FILES_TO_ENTRIES_CACHE_LOCATION'
+			env: 'SFGE_FILES_TO_ENTRIES_CACHE_LOCATION',
+			hidden: true
 		}),
 		// END: Config-overrideable engine flags.
 	};

diff --git a/src/lib/EngineOptionsFactory.ts b/src/lib/EngineOptionsFactory.ts
@@ -28,9 +28,7 @@ abstract class CommonEngineOptionsFactory implements EngineOptionsFactory {
 		const options: Map<string,string> = new Map();
 		if (this.shouldSfgeRun(inputs)) {
 			const sfgeConfig: SfgeConfig = {
-				projectDirs: this.inputProcessor.resolveProjectDirPaths(inputs),
-				cachepath: inputs.cachepath as string,
-				enablecaching: inputs.enablecaching as boolean
+				projectDirs: this.inputProcessor.resolveProjectDirPaths(inputs)
 			};
 			options.set(CUSTOM_CONFIG.SfgeConfig, JSON.stringify(sfgeConfig));
 		}

diff --git a/src/lib/sfge/SfgeWrapper.ts b/src/lib/sfge/SfgeWrapper.ts
@@ -33,8 +33,6 @@ type SfgeWrapperOptions = {
 	spinnerManager: SpinnerManager;
 	jvmArgs?: string;
 	pathExpLimit?: number;
-	enablecaching?: boolean;
-	cachepath?: string;
 }
 
 type SfgeCatalogOptions = SfgeWrapperOptions & {
@@ -170,7 +168,6 @@ abstract class AbstractSfgeWrapper extends CommandLineSupport {
 		}
 		args.push(...this.getSupplementalFlags(), MAIN_CLASS, this.action, ...(await this.getSupplementalArgs()));
 		this.logger.trace(`Preparing to execute sfge with command: "${command}", args: "${JSON.stringify(args)}"`);
-		console.log(`Preparing to execute sfge with command: "${command}", args: "${JSON.stringify(args)}"`);
 		return [command, args];
 	}
 	protected async execute(): Promise<string> {