CHANGE (CodeAnalyzer): @W-14009441@: create output file when no violations are found #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@W-14009441@: fill in fake header for csv output @W-14009441@: clean comments/documentation @W-14009441@: fix ancillary tests
MrEminent42
force-pushed
the
d/W-14009441
branch
from
1ec8969 to
4bd02ee
Compare
MrEminent42
commented
Sep 5, 2023
| @@ -1,7 +1,6 @@ | |||
| module.exports = { | |||
| "output": { | |||
| "engineSummaryTemplate": "Executed %s, found %s violation(s) across %s file(s).", | |||
| "noViolationsDetected": "Executed engines: %s. No rule violations found.", | |||
There was a problem hiding this comment.
This message is now no longer used, anywhere. Instead, the above message is used. If there are no violations, a message similar to Executed sfge, found 0 violation(s) across 0 file(s) is printed.
Comment on lines
-31
to
-40
| const {minSev, summaryMap, results} = rrr; | ||
| // If the results are an empty string, it means no violations were found. | ||
| if (results === '') { | ||
| // Build an appropriate message... | ||
| const msg = messages.getMessage('output.noViolationsDetected', [[...summaryMap.keys()].join(', ')]); | ||
| // ...log it to the console... | ||
| this.ux.log(msg); | ||
| // ...and return it for use with the --json flag. | ||
| return msg; | ||
| } |
There was a problem hiding this comment.
Removing this shortcut return is the main change here. The logic below works fine with 0 violations, it now returns [] when there are no violations, instead of an empty string.
Most of the other changes in this PR are a result of removing these lines. The other changes involve updating the automated tests.
jfeingold35
reviewed
Sep 7, 2023
jfeingold35
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
outfileis specified and no violations are found.