CHANGE @W-17053004@ Polished run command output #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfeingold35
force-pushed
the
d/W-17053004
branch
from
57f700b to
6f2a293
Compare
| @@ -123,8 +114,7 @@ export class ResultsTableDisplayer extends AbstractResultsDisplayer { | |||
| } | |||
| }); | |||
|
|
|||
| this.display.displayLog(getMessage(BundleName.ResultsViewer, 'summary.table.found-results', [ | |||
| violations.length, this.countUniqueFiles(violations), parentFolder])); | |||
| this.display.displayLog(getMessage(BundleName.ResultsViewer, 'summary.table.results-relative-to', [parentFolder])); | |||
There was a problem hiding this comment.
Do we need to show this if there are no results?
There was a problem hiding this comment.
It doesn't show if there are no results. The method is only called when there are results to show.
stephen-carter-at-sf
approved these changes
Nov 8, 2024
jfeingold35
force-pushed
the
d/W-17053004
branch
from
6f2a293 to
854e2aa
Compare
jfeingold35
force-pushed
the
d/W-17053004
branch
from
854e2aa to
e50d4f9
Compare
jfeingold35
commented
Nov 15, 2024
There was a problem hiding this comment.
New messages are the still-relevant ones from the now-deleted run-summary-viewer.md.
| @@ -75,6 +75,64 @@ export class RulesActionSummaryViewer extends AbstractActionSummaryViewer { | |||
| this.display.displayLog(indent(getMessage(BundleName.ActionSummaryViewer, 'rules-action.rules-item', [ruleCountForEngine, engineName]))); | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| export class RunActionSummaryViewer extends AbstractActionSummaryViewer { | |||
There was a problem hiding this comment.
This code is almost identical to the code from RunSummaryViewer.ts, but it's different to accomplish the goals of the story.
stephen-carter-at-sf
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Found X violations across Y filesmessage to the Summary portion of the output instead of the View portion.detailformat no longer has a message.tableformat just says what the paths are relative to.