CHANGE: @W-17272495@: Polish detail view output #1678
Conversation
...s/comparison-files/lib/viewers/ResultsViewer.test.ts/one-multilocation-violation-details.txt
Outdated
Show resolved
Hide resolved
| (main) __PATH_TO_FILE_Z__:2:1 This is a comment at Location 2 | ||
| __PATH_TO_FILE_A__:1:1 This is a comment at Location 3 | ||
| resources: https://example.com/stub1RuleA | ||
| (main) __PATH_TO_FILE_Z__:2:1 "This is a comment at Location 2" |
There was a problem hiding this comment.
Why is this just 2:1 instead of 2:1-7?
There was a problem hiding this comment.
Good question. The way Core is currently implemented over at https://github.com/forcedotcom/code-analyzer-core/blob/dev/packages/code-analyzer-core/src/results.ts#L72 is to say that we do not actually return an endColumn if it doesn't have an associated endLine since it'll force clients to each make their own decisions as to what to do. It's just easier to that engines must supply endLine if they want to supply endColumn.
There was a problem hiding this comment.
But then why does this violation have an endColumn at all in the declaration? (see 149 of the test file).
There was a problem hiding this comment.
It doesn't - it's just a sanity check in case we ever change what the core module does... I want the test to fail somehow so we know what to do with it.
...s/comparison-files/lib/viewers/ResultsViewer.test.ts/one-multilocation-violation-details.txt
Outdated
Show resolved
Hide resolved
stephen-carter-at-sf
force-pushed
the
sc/polishDetailView
branch
from
377c5b0 to
065608a
Compare
No description provided.