CHANGE: @W-17321151@: Only show fields in detail view of rules command if they are non-empty #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and if they are non-empty
jfeingold35
reviewed
Nov 27, 2024
Comment on lines
+48
to
+51
| if (rule.getTags().length > 0) { | ||
| body['tags'] = rule.getTags().join(', '); | ||
| keys.push('tags'); | ||
| } |
There was a problem hiding this comment.
I think there might be value in having a tag-less rule display with tags: none or something like that.
There was a problem hiding this comment.
You'll have to ask John and Marcelino if that's what they want. Last I heard, we just wanted to hide the fields if they were empty.
Comment on lines
+61
to
+64
| if (rule.getDescription().length > 0) { | ||
| body['description'] = rule.getDescription(); | ||
| keys.push('description'); | ||
| } |
There was a problem hiding this comment.
Genuine question: Why is it valid for a rule to have no description? That seems like it should be a required property.
There was a problem hiding this comment.
IDK... if people don't put in a description in their custom PMD that might occur.
jfeingold35
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.