CHANGE (CodeAnalyzer) @W-17312010@ Preparing dev-4 to replace dev as v4 home branch #1695
Conversation
jfeingold35
force-pushed
the
d/W-17312010-v4
branch
from
c8d9243 to
950fb46
Compare
jfeingold35
force-pushed
the
d/W-17312010-v4
branch
from
950fb46 to
bfd289d
Compare
| @@ -22,7 +22,7 @@ jobs: | |||
| # === Setup. We need to get the code, set up nodejs, and create the results directory. === | |||
| - uses: actions/checkout@v4 | |||
| with: | |||
| ref: 'release' | |||
| ref: 'main-4' | |||
There was a problem hiding this comment.
release was technically incorrect here, since main (soon to be main-4) is the production branch for v4. It wasn't causing any problems because it's been ages since we made a breaking change in v4, but it's still worth correcting.
| workflow_call: # As per documentation, the colon is necessary even though no config is required. | ||
| workflow_dispatch: # As per documentation, the colon is necessary even though no config is required. | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
With one exception called out below, this is identical to the body of the old Heartbeat workflow, moved into its own file so it can be invoked via workflow_dispatch within the v5 ecosystem (which I imagine we'll want to do until v5 goes GA).
| # === Setup. We need to get the code, set up nodejs, and create the results directory. === | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| ref: 'main-4' |
There was a problem hiding this comment.
In the original workflow, this was release, which was a mistake. It should have been main, since that was the production branch for v4. This hasn't caused any issues since there have been no breaking changes to v4 in many months, but should be corrected here.
| } | ||
| # Make our POST request | ||
| curl --request POST --data "$(generate_post_data)" https://events.pagerduty.com/v2/enqueue | ||
| jobs: |
There was a problem hiding this comment.
This is technically unnecessary, since un-defaulting dev-4 will disable the cron job that causes this workflow to run. But I'm doing it anyway to be thorough, and because we might need to make v4 the default branch again in the future or something like that, and it's worth being prepared.
jfeingold35
changed the title
No description provided.