Skip to content

Commit

Permalink
chore: updates from devScripts (#1255)
Browse files Browse the repository at this point in the history
  • Loading branch information
svc-cli-bot authored Mar 10, 2024
1 parent db5fdfd commit 2a18348
Show file tree
Hide file tree
Showing 4 changed files with 202 additions and 260 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
},
"devDependencies": {
"@salesforce/cli-plugins-testkit": "^5.1.10",
"@salesforce/dev-scripts": "^8.4.1",
"@salesforce/dev-scripts": "^8.4.2",
"@types/deep-equal-in-any-order": "^1.0.1",
"@types/fast-levenshtein": "^0.0.4",
"@types/graceful-fs": "^4.1.9",
Expand Down
2 changes: 1 addition & 1 deletion src/registry/coverage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { CoverageObject } from '../../src/registry/types';

const getProxiedOptions = (url: string): OptionsOfTextResponseBody => ({
timeout: {
request: 10000,
request: 10_000,
},
agent: {
https: new ProxyAgent(),
Expand Down
12 changes: 6 additions & 6 deletions test/convert/metadataConverter.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ describe('MetadataConverter', () => {
});

it('should generate package name using timestamp when option omitted', async () => {
const timestamp = 123456;
const timestamp = 123_456;
const packagePath = join(outputDirectory, `${MetadataConverter.DEFAULT_PACKAGE_PREFIX}_${timestamp}`);
$$.SANDBOX.stub(Date, 'now').returns(timestamp);

Expand Down Expand Up @@ -149,7 +149,7 @@ describe('MetadataConverter', () => {
});

it('should write manifest for metadata format conversion', async () => {
const timestamp = 123456;
const timestamp = 123_456;
const packagePath = join(outputDirectory, `${MetadataConverter.DEFAULT_PACKAGE_PREFIX}_${timestamp}`);
$$.SANDBOX.stub(Date, 'now').returns(timestamp);
const expectedContents = await new ComponentSet(components).getPackageXml();
Expand All @@ -164,7 +164,7 @@ describe('MetadataConverter', () => {
});

it('should write destructive changes post manifest when ComponentSet has deletes marked for post', async () => {
const timestamp = 123456;
const timestamp = 123_456;
const packagePath = join(outputDirectory, `${MetadataConverter.DEFAULT_PACKAGE_PREFIX}_${timestamp}`);
$$.SANDBOX.stub(Date, 'now').returns(timestamp);
const component1 = new SourceComponent({
Expand Down Expand Up @@ -196,7 +196,7 @@ describe('MetadataConverter', () => {
});

it('should write destructive changes pre manifest when ComponentSet has deletes', async () => {
const timestamp = 123456;
const timestamp = 123_456;
const packagePath = join(outputDirectory, `${MetadataConverter.DEFAULT_PACKAGE_PREFIX}_${timestamp}`);
$$.SANDBOX.stub(Date, 'now').returns(timestamp);
const component1 = new SourceComponent({
Expand Down Expand Up @@ -229,7 +229,7 @@ describe('MetadataConverter', () => {
});

it('should write manifest for metadata format conversion with sourceApiVersion', async () => {
const timestamp = 123456;
const timestamp = 123_456;
const packagePath = join(outputDirectory, `${MetadataConverter.DEFAULT_PACKAGE_PREFIX}_${timestamp}`);
$$.SANDBOX.stub(Date, 'now').returns(timestamp);
const compSet = new ComponentSet(components);
Expand All @@ -247,7 +247,7 @@ describe('MetadataConverter', () => {
});

it('should write the fullName entry when packageName is provided', async () => {
const timestamp = 123456;
const timestamp = 123_456;
const packageName = 'examplePackage';
const packagePath = join(outputDirectory, packageName);
$$.SANDBOX.stub(Date, 'now').returns(timestamp);
Expand Down
Loading

0 comments on commit 2a18348

Please sign in to comment.