Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tests for cross-language exact reproducibility #102

Merged
merged 5 commits into from
Apr 30, 2023
Merged

Conversation

edwardwliu
Copy link
Collaborator

@edwardwliu edwardwliu commented Apr 22, 2023

Runs check for exact predictions between R and Python packages for the following behaviors:

  • default parameters
  • oob_honest
  • groups
  • oob_honest and groups

@edwardwliu edwardwliu self-assigned this Apr 22, 2023
@edwardwliu edwardwliu added the CI/CD Changes which affect CI/CD only label Apr 22, 2023
@edwardwliu edwardwliu marked this pull request as ready for review April 28, 2023 13:00
@edwardwliu
Copy link
Collaborator Author

Ideally in a future PR, we can update the outputs to be single line in a future PR. For now, I'd like to merge these tests and release the new version of the Python package 0.10.0 to PyPI today. Thanks for setting up this infra @petrovicboban .

@theo-s The sklearn check PR is blocked on correctly pickling the model, which is a larger fix that we should try to resolve shortly. It would be helpful to include this in the next update.

@theo-s theo-s merged commit 17011a9 into master Apr 30, 2023
@theo-s
Copy link
Contributor

theo-s commented Apr 30, 2023

I can take a look at the problem with the pickling of the model, it sounds like this shouldn't be that hard to change, but unfortunately, I am pretty busy during the next two weeks. Will try to work on this sometime, but might take a little longer to get too.

@petrovicboban petrovicboban deleted the cross_test branch May 1, 2023 13:29
@petrovicboban petrovicboban added the ignore-for-release Don't include this PR in release notes label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Changes which affect CI/CD only ignore-for-release Don't include this PR in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants