fixing child components being displayed when they should be removed when clearOnHide is set #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen clearOnHide is set
johnformio
commented
Jul 18, 2024
Comment on lines
-15
to
-23
| const skipOnServer = (context: ConditionsContext): boolean => { | ||
| const { component, config } = context; | ||
| const clearOnHide = component.hasOwnProperty('clearOnHide') ? component.clearOnHide : true; | ||
| if (config?.server && !clearOnHide) { | ||
| // No need to run conditionals on server unless clearOnHide is set. | ||
| return true; | ||
| } | ||
| return false; | ||
| }; |
johnformio
commented
Jul 18, 2024
Comment on lines
+103
to
104
| // the path set here is not the absolute path, but the path relative to the parent component | ||
| scope.conditionals?.push({ path: getComponentPath(comp, compPath), conditionallyHidden: true }); |
There was a problem hiding this comment.
this sets a partial path to the parent <parent-key>.<field-key> not an absolute path
johnformio
commented
Jul 18, 2024
| const conditionallyHidden = (scope as ConditionsScope).conditionals?.find((cond) => { | ||
| return cond.path === path; | ||
| return path.includes(cond.path); |
There was a problem hiding this comment.
the path set in the conditionals is partial, relaxing the check from exact match to component path contains the conditional path
travist
approved these changes
Jul 18, 2024
lane-formio
added a commit
that referenced
this pull request
Jul 30, 2024
fixing child components being displayed when they should be removed when clearOnHide is set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-8537
Description
The issue was that fields that should have been hidden on the submission were
What changed?
two things changed:
conditionalProcessfunction there was a check to see if clearOnHide was checked before setting the conditional fields in the context scope. This was removed.clearHiddenProcessfunction, the path in the conditional scope entries were checking the complete path of the component to determine if the submission data should be removed. However, the path being set in scope conditional array is a relative path from the parent, and therefore skipped. The change was to do a partial match on the conditional path to see if it should be omitted.Breaking Changes / Backwards Compatibility
Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility
Dependencies
None
How has this PR been tested?
unit tests
Use this section to describe how you tested your changes; if you haven't included automated tests, justify your reasoning
Checklist: