Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8769 added check for the simpleConditional properties state #136

Conversation

HannaKurban
Copy link
Contributor

@HannaKurban HannaKurban commented Aug 16, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8769

Description

Fixed behavior when hidden property wasn't work when the conditional is saved in an invalid state. Added check of the Simple Conditions properties and added validation for Conditional tab on EditForm modal window

Breaking Changes / Backwards Compatibility

n/a

Dependencies

https://github.com/formio/premium/pull/320

How has this PR been tested?

Automated tests has been added

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@travist travist merged commit 6c3ff4d into master Aug 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants