Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8848 fixed validation for TextArea with Save as Json #138

Conversation

HannaKurban
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8848

Description

Fixed an issue with saving a value for non multiple Text Area componentl if the "Save as" property is set to "json". Previously, if non multiple Text Area with 'Save As'= 'json' was filled in as an array, 'nonarray' Error was displayed. This caused regression when it was not possible to save Select component with Data Source Type Raw JSON. This has been fixed by adding an additional condition for validateMultiple

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

Automated test has been added

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit d596125 into master Aug 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants