Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8901: Fixed incorrect handling of excessive rows in nested array model #142

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

roma-formio
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8901

Description

Issue: When setting a nested array model's dataValue to a smaller size than it was previously, the new dataValue contains more items than it should. This happens because when we remove excessive items by iterating over the array from the beginning, each removal causes the subsequent elements to shift left, leading to skipped elements during iteration.

Solution: Iterate over the array in reverse order to avoid skipping elements when removing items.

How has this PR been tested?

Updated the existing test case.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@lane-formio lane-formio merged commit ac66b9b into master Aug 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants