FIO-8901: Fixed incorrect handling of excessive rows in nested array model #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-8901
Description
Issue: When setting a nested array model's
dataValue
to a smaller size than it was previously, the newdataValue
contains more items than it should. This happens because when we remove excessive items by iterating over the array from the beginning, each removal causes the subsequent elements to shift left, leading to skipped elements during iteration.Solution: Iterate over the array in reverse order to avoid skipping elements when removing items.
How has this PR been tested?
Updated the existing test case.
Checklist: