Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9280 updated validation of value property #185

Conversation

HannaKurban
Copy link
Contributor

@HannaKurban HannaKurban commented Nov 4, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9280

Description

Since the Radio component and the Select component support various data types, including objects and boolean values, validation of the value property is triggered only for the Select Boxes component. Also, validation is triggered only in the form builder. If the value for the SelectBoxes component is invalid, an error is displayed that does not allow saving the component with invalid values.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

formio/formio.js#5894

How has this PR been tested?

locally, automated tests have been added

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@travist
Copy link
Member

travist commented Nov 4, 2024

👍

@travist travist merged commit 2278307 into master Nov 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants