Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9159: change clearOnHide behavior to track conditionally hidden state rather than mere visibility #5902

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brendanbond
Copy link
Contributor

@brendanbond brendanbond commented Nov 11, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9159

Description

This commit changes the behavior of the clearOnHide property. Previously, when this flag was present in a component, the renderer would unset the component's value from submission data if it was not visible (so, conditionally hidden, logically hidden, or intentionally hidden via the hidden property). Now, clearOnHide will only unset the component's data if it or its parent is conditionally or logically hidden. The copy of the parameter in the builder has also been changed.

Breaking Changes / Backwards Compatibility

This constitutes a breaking change. The clearOnHide property no longer functions the way that it used to. A component with clearOnHide enabled will "clear" the component's value if the component or its parent is conditionally hidden.

Dependencies

@formio/core#173

How has this PR been tested?

Manual + automated tests

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

…sly, when this flag was present in a component, the renderer would unset the component's value from submission data if it was not visible (so, conditionally hidden, logically hidden, or intentionally hidden via the hidden property). Now, clearOnHide will only unset the component's data if it or its parent is conditionally or logically hidden. The copy of the parameter in the builder has also been changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant