Merge pull request #165 from forntoh/bugfix/setcursorposition-bug

forntoh · Mar 8, 2024 · 46375a4 · 46375a4
2 parents 581adf0 + daff011
commit 46375a4
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/src/LcdMenu.h b/src/LcdMenu.h
@@ -856,7 +856,20 @@ class LcdMenu {
      * @param position
      */
     void setCursorPosition(uint8_t position) {
-        this->cursorPosition = position;
+        uint8_t bottom = position;
+        bool isNotEnd = false;
+
+        do {
+            isNotEnd = currentMenuTable[++bottom]->getType() !=
+                           MENU_ITEM_END_OF_MENU &&
+                       bottom < maxRows + 20;
+        } while (isNotEnd);
+
+        uint8_t max = maxRows - 1;
+
+        this->cursorPosition = position + 1;
+        this->bottom = constrain(cursorPosition + max, max, bottom - 1);
+        this->top = this->bottom - max;
     }
     /**
      * Update timer and turn off display on timeout