-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/refactor items #221
Merged
forntoh
merged 10 commits into
forntoh:feature/move-control-to-items
from
ShishkinDmitriy:feature/refactor-items
Sep 21, 2024
Merged
Feature/refactor items #221
forntoh
merged 10 commits into
forntoh:feature/move-control-to-items
from
ShishkinDmitriy:feature/refactor-items
Sep 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory usage change @ 742f050
Click for full report table
Click for full report CSV
|
forntoh
reviewed
Sep 21, 2024
forntoh
reviewed
Sep 21, 2024
forntoh
reviewed
Sep 21, 2024
forntoh
reviewed
Sep 21, 2024
forntoh
previously approved these changes
Sep 21, 2024
…mitriy/LcdMenu into feature/refactor-items
forntoh
approved these changes
Sep 21, 2024
forntoh
merged commit Sep 21, 2024
830fbf4
into
forntoh:feature/move-control-to-items
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to rename methods from up/down/left/right into specific for item, something like more 'domain specific':
changeScreen
forItemBack
andItemSubMenu
insted ofenter
.commitCharEdit
forItemInputCharset
instead ofenter
.Also signature of
process
simplified and instead ofContext
pass onlyLcdMenu
and char.All required dependencies (display and current screen) can be obtained from menu.
Also true/false result for process method is controlled inside process method. Also simplified repeated if's
Also need somehow separate value update and draw.