Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update various item setters #225

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

forntoh
Copy link
Owner

@forntoh forntoh commented Sep 23, 2024

  • Added return value to setValue methods for ItemInput and ItemList classes
  • Updated setItemIndex method in ItemList class to return a boolean

- Added return value to setValue methods for ItemInput and ItemList classes
- Updated setItemIndex method in ItemList class to return a boolean
@forntoh forntoh added this to the LcdMenu 5.0.0 milestone Sep 23, 2024
Copy link
Contributor

Memory usage change @ 877c322

Board flash % RAM for global variables %
arduino:avr:uno 🔺 0 - +38 0.0 - +0.12 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Basic
flash
% examples/Basic
RAM for global variables
% examples/ButtonAdapter
flash
% examples/ButtonAdapter
RAM for global variables
% examples/ButtonWithRotaryAdapter
flash
% examples/ButtonWithRotaryAdapter
RAM for global variables
% examples/Callbacks
flash
% examples/Callbacks
RAM for global variables
% examples/CharsetInput
flash
% examples/CharsetInput
RAM for global variables
% examples/InputRotary
flash
% examples/InputRotary
RAM for global variables
% examples/IntFloatValues
flash
% examples/IntFloatValues
RAM for global variables
% examples/ItemBack
flash
% examples/ItemBack
RAM for global variables
% examples/KeyboardAdapter
flash
% examples/KeyboardAdapter
RAM for global variables
% examples/List
flash
% examples/List
RAM for global variables
% examples/MenuTimeout
flash
% examples/MenuTimeout
RAM for global variables
% examples/RTOS
flash
% examples/RTOS
RAM for global variables
% examples/SimpleInput
flash
% examples/SimpleInput
RAM for global variables
% examples/SimpleRotary
flash
% examples/SimpleRotary
RAM for global variables
% examples/SubMenu
flash
% examples/SubMenu
RAM for global variables
%
arduino:avr:uno 0 0.0 0 0.0 0 0.0 0 0.0 22 0.07 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 38 0.12 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 20 0.06 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 22 0.07 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/Basic<br>flash,%,examples/Basic<br>RAM for global variables,%,examples/ButtonAdapter<br>flash,%,examples/ButtonAdapter<br>RAM for global variables,%,examples/ButtonWithRotaryAdapter<br>flash,%,examples/ButtonWithRotaryAdapter<br>RAM for global variables,%,examples/Callbacks<br>flash,%,examples/Callbacks<br>RAM for global variables,%,examples/CharsetInput<br>flash,%,examples/CharsetInput<br>RAM for global variables,%,examples/InputRotary<br>flash,%,examples/InputRotary<br>RAM for global variables,%,examples/IntFloatValues<br>flash,%,examples/IntFloatValues<br>RAM for global variables,%,examples/ItemBack<br>flash,%,examples/ItemBack<br>RAM for global variables,%,examples/KeyboardAdapter<br>flash,%,examples/KeyboardAdapter<br>RAM for global variables,%,examples/List<br>flash,%,examples/List<br>RAM for global variables,%,examples/MenuTimeout<br>flash,%,examples/MenuTimeout<br>RAM for global variables,%,examples/RTOS<br>flash,%,examples/RTOS<br>RAM for global variables,%,examples/SimpleInput<br>flash,%,examples/SimpleInput<br>RAM for global variables,%,examples/SimpleRotary<br>flash,%,examples/SimpleRotary<br>RAM for global variables,%,examples/SubMenu<br>flash,%,examples/SubMenu<br>RAM for global variables,%
arduino:avr:uno,0,0.0,0,0.0,0,0.0,0,0.0,22,0.07,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,38,0.12,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,20,0.06,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,22,0.07,0,0.0,0,0.0,0,0.0

@forntoh forntoh enabled auto-merge (squash) September 23, 2024 13:24
Copy link
Contributor

Memory usage change @ fe4d1cc

Board flash % RAM for global variables %
arduino:avr:uno 🔺 0 - +38 0.0 - +0.12 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Basic
flash
% examples/Basic
RAM for global variables
% examples/ButtonAdapter
flash
% examples/ButtonAdapter
RAM for global variables
% examples/ButtonWithRotaryAdapter
flash
% examples/ButtonWithRotaryAdapter
RAM for global variables
% examples/Callbacks
flash
% examples/Callbacks
RAM for global variables
% examples/CharsetInput
flash
% examples/CharsetInput
RAM for global variables
% examples/InputRotary
flash
% examples/InputRotary
RAM for global variables
% examples/IntFloatValues
flash
% examples/IntFloatValues
RAM for global variables
% examples/ItemBack
flash
% examples/ItemBack
RAM for global variables
% examples/KeyboardAdapter
flash
% examples/KeyboardAdapter
RAM for global variables
% examples/List
flash
% examples/List
RAM for global variables
% examples/MenuTimeout
flash
% examples/MenuTimeout
RAM for global variables
% examples/RTOS
flash
% examples/RTOS
RAM for global variables
% examples/SimpleInput
flash
% examples/SimpleInput
RAM for global variables
% examples/SimpleRotary
flash
% examples/SimpleRotary
RAM for global variables
% examples/SubMenu
flash
% examples/SubMenu
RAM for global variables
%
arduino:avr:uno 0 0.0 0 0.0 0 0.0 0 0.0 18 0.06 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 38 0.12 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 18 0.06 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 18 0.06 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/Basic<br>flash,%,examples/Basic<br>RAM for global variables,%,examples/ButtonAdapter<br>flash,%,examples/ButtonAdapter<br>RAM for global variables,%,examples/ButtonWithRotaryAdapter<br>flash,%,examples/ButtonWithRotaryAdapter<br>RAM for global variables,%,examples/Callbacks<br>flash,%,examples/Callbacks<br>RAM for global variables,%,examples/CharsetInput<br>flash,%,examples/CharsetInput<br>RAM for global variables,%,examples/InputRotary<br>flash,%,examples/InputRotary<br>RAM for global variables,%,examples/IntFloatValues<br>flash,%,examples/IntFloatValues<br>RAM for global variables,%,examples/ItemBack<br>flash,%,examples/ItemBack<br>RAM for global variables,%,examples/KeyboardAdapter<br>flash,%,examples/KeyboardAdapter<br>RAM for global variables,%,examples/List<br>flash,%,examples/List<br>RAM for global variables,%,examples/MenuTimeout<br>flash,%,examples/MenuTimeout<br>RAM for global variables,%,examples/RTOS<br>flash,%,examples/RTOS<br>RAM for global variables,%,examples/SimpleInput<br>flash,%,examples/SimpleInput<br>RAM for global variables,%,examples/SimpleRotary<br>flash,%,examples/SimpleRotary<br>RAM for global variables,%,examples/SubMenu<br>flash,%,examples/SubMenu<br>RAM for global variables,%
arduino:avr:uno,0,0.0,0,0.0,0,0.0,0,0.0,18,0.06,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,38,0.12,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,18,0.06,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,18,0.06,0,0.0,0,0.0,0,0.0

@forntoh forntoh merged commit 23bc8eb into feature/move-control-to-items Sep 23, 2024
15 checks passed
@forntoh forntoh deleted the tf/update-item-setters branch September 23, 2024 17:04
@forntoh forntoh added the enhancement Improve readability/performance/maintainability label Oct 7, 2024
@github-actions github-actions bot mentioned this pull request Oct 7, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve readability/performance/maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants