Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable jumping to upper bound when lower bound reached #226

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Enable jumping to upper bound when lower bound reached #226

merged 3 commits into from
Sep 23, 2024

Conversation

forntoh
Copy link
Owner

@forntoh forntoh commented Sep 23, 2024

Adjust item selection logic to allow jumping from the lower bound to the upper bound when navigating through items.

This enables the user to cycle through the items in both ways using only one action.

@forntoh forntoh added this to the LcdMenu v5.0.0 milestone Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Memory usage change @ ca989fd

Board flash % RAM for global variables %
arduino:avr:uno 💚 -10 - 0 -0.03 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Basic
flash		 % examples/Basic
RAM for global variables		 % examples/ButtonAdapter
flash		 % examples/ButtonAdapter
RAM for global variables		 % examples/ButtonWithRotaryAdapter
flash		 % examples/ButtonWithRotaryAdapter
RAM for global variables		 % examples/Callbacks
flash		 % examples/Callbacks
RAM for global variables		 % examples/CharsetInput
flash		 % examples/CharsetInput
RAM for global variables		 % examples/InputRotary
flash		 % examples/InputRotary
RAM for global variables		 % examples/IntFloatValues
flash		 % examples/IntFloatValues
RAM for global variables		 % examples/ItemBack
flash		 % examples/ItemBack
RAM for global variables		 % examples/KeyboardAdapter
flash		 % examples/KeyboardAdapter
RAM for global variables		 % examples/List
flash		 % examples/List
RAM for global variables		 % examples/MenuTimeout
flash		 % examples/MenuTimeout
RAM for global variables		 % examples/RTOS
flash		 % examples/RTOS
RAM for global variables		 % examples/SimpleInput
flash		 % examples/SimpleInput
RAM for global variables		 % examples/SimpleRotary
flash		 % examples/SimpleRotary
RAM for global variables		 % examples/SubMenu
flash		 % examples/SubMenu
RAM for global variables		 %
arduino:avr:uno 0 0.0 0 0.0 0 0.0 0 0.0 -10 -0.03 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -6 -0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -10 -0.03 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/Basic<br>flash,%,examples/Basic<br>RAM for global variables,%,examples/ButtonAdapter<br>flash,%,examples/ButtonAdapter<br>RAM for global variables,%,examples/ButtonWithRotaryAdapter<br>flash,%,examples/ButtonWithRotaryAdapter<br>RAM for global variables,%,examples/Callbacks<br>flash,%,examples/Callbacks<br>RAM for global variables,%,examples/CharsetInput<br>flash,%,examples/CharsetInput<br>RAM for global variables,%,examples/InputRotary<br>flash,%,examples/InputRotary<br>RAM for global variables,%,examples/IntFloatValues<br>flash,%,examples/IntFloatValues<br>RAM for global variables,%,examples/ItemBack<br>flash,%,examples/ItemBack<br>RAM for global variables,%,examples/KeyboardAdapter<br>flash,%,examples/KeyboardAdapter<br>RAM for global variables,%,examples/List<br>flash,%,examples/List<br>RAM for global variables,%,examples/MenuTimeout<br>flash,%,examples/MenuTimeout<br>RAM for global variables,%,examples/RTOS<br>flash,%,examples/RTOS<br>RAM for global variables,%,examples/SimpleInput<br>flash,%,examples/SimpleInput<br>RAM for global variables,%,examples/SimpleRotary<br>flash,%,examples/SimpleRotary<br>RAM for global variables,%,examples/SubMenu<br>flash,%,examples/SubMenu<br>RAM for global variables,%
arduino:avr:uno,0,0.0,0,0.0,0,0.0,0,0.0,-10,-0.03,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-6,-0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-10,-0.03,0,0.0,0,0.0,0,0.0

@github-actions GitHub Actions
Copy link
Contributor

Memory usage change @ 5203afb

Board flash % RAM for global variables %
arduino:avr:uno 💚 -10 - 0 -0.03 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Basic
flash		 % examples/Basic
RAM for global variables		 % examples/ButtonAdapter
flash		 % examples/ButtonAdapter
RAM for global variables		 % examples/ButtonWithRotaryAdapter
flash		 % examples/ButtonWithRotaryAdapter
RAM for global variables		 % examples/Callbacks
flash		 % examples/Callbacks
RAM for global variables		 % examples/CharsetInput
flash		 % examples/CharsetInput
RAM for global variables		 % examples/InputRotary
flash		 % examples/InputRotary
RAM for global variables		 % examples/IntFloatValues
flash		 % examples/IntFloatValues
RAM for global variables		 % examples/ItemBack
flash		 % examples/ItemBack
RAM for global variables		 % examples/KeyboardAdapter
flash		 % examples/KeyboardAdapter
RAM for global variables		 % examples/List
flash		 % examples/List
RAM for global variables		 % examples/MenuTimeout
flash		 % examples/MenuTimeout
RAM for global variables		 % examples/RTOS
flash		 % examples/RTOS
RAM for global variables		 % examples/SimpleInput
flash		 % examples/SimpleInput
RAM for global variables		 % examples/SimpleRotary
flash		 % examples/SimpleRotary
RAM for global variables		 % examples/SubMenu
flash		 % examples/SubMenu
RAM for global variables		 %
arduino:avr:uno 0 0.0 0 0.0 0 0.0 0 0.0 -10 -0.03 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -6 -0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -10 -0.03 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/Basic<br>flash,%,examples/Basic<br>RAM for global variables,%,examples/ButtonAdapter<br>flash,%,examples/ButtonAdapter<br>RAM for global variables,%,examples/ButtonWithRotaryAdapter<br>flash,%,examples/ButtonWithRotaryAdapter<br>RAM for global variables,%,examples/Callbacks<br>flash,%,examples/Callbacks<br>RAM for global variables,%,examples/CharsetInput<br>flash,%,examples/CharsetInput<br>RAM for global variables,%,examples/InputRotary<br>flash,%,examples/InputRotary<br>RAM for global variables,%,examples/IntFloatValues<br>flash,%,examples/IntFloatValues<br>RAM for global variables,%,examples/ItemBack<br>flash,%,examples/ItemBack<br>RAM for global variables,%,examples/KeyboardAdapter<br>flash,%,examples/KeyboardAdapter<br>RAM for global variables,%,examples/List<br>flash,%,examples/List<br>RAM for global variables,%,examples/MenuTimeout<br>flash,%,examples/MenuTimeout<br>RAM for global variables,%,examples/RTOS<br>flash,%,examples/RTOS<br>RAM for global variables,%,examples/SimpleInput<br>flash,%,examples/SimpleInput<br>RAM for global variables,%,examples/SimpleRotary<br>flash,%,examples/SimpleRotary<br>RAM for global variables,%,examples/SubMenu<br>flash,%,examples/SubMenu<br>RAM for global variables,%
arduino:avr:uno,0,0.0,0,0.0,0,0.0,0,0.0,-10,-0.03,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-6,-0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-10,-0.03,0,0.0,0,0.0,0,0.0

Base automatically changed from tf/update-item-setters to feature/move-control-to-items September 23, 2024 17:04
@forntoh forntoh dismissed ShishkinDmitriy’s stale review September 23, 2024 17:04

The base branch was changed.

@forntoh forntoh marked this pull request as ready for review September 23, 2024 17:13
@forntoh
Enable jumping to upper bound when lower bound reached
c138c73 
Adjust item selection logic to allow jumping from the lower bound to the upper bound when navigating through items.

This enables the user to cycle through the items in both ways using only one action.
@forntoh
Update test case
16d8e60
@forntoh
Fix test file
3caf69f
@forntoh forntoh merged commit 686fbcd into feature/move-control-to-items Sep 23, 2024
15 checks passed
@forntoh forntoh deleted the tf/unbounded-list branch September 23, 2024 19:17
@forntoh forntoh added the enhancement Improve readability/performance/maintainability label Oct 7, 2024
@github-actions github-actions bot mentioned this pull request Oct 7, 2024
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShishkinDmitriy ShishkinDmitriy ShishkinDmitriy left review comments

Assignees
No one assigned
Labels
enhancement Improve readability/performance/maintainability
Projects
None yet
Milestone
LcdMenu v5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@forntoh @ShishkinDmitriy