Skip to content

Commit

Permalink
chore: add todo comments
Browse files Browse the repository at this point in the history
- Add todo comments for removing global variables.
  • Loading branch information
Taowyoo committed May 7, 2024
1 parent 0378b16 commit 72d6142
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions cmd/getVersion.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
"github.com/spf13/cobra"
)

// TODO: get rid of global variables, tracking issue: #16
var getVersionCount uint
var newConnectionPerRequest bool
var getVersionDelay time.Duration
Expand Down
1 change: 1 addition & 0 deletions cmd/loadTest.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import (
"github.com/spf13/cobra"
)

// TODO: get rid of global variables, tracking issue: #16
var queriesPerSecond uint
var connections uint
var warmupDuration time.Duration
Expand Down
1 change: 1 addition & 0 deletions cmd/loadTestGenerateKey.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import (
"github.com/spf13/cobra"
)

// TODO: get rid of global variables, tracking issue: #16
var keyType = objectTypeAES
var keySize uint32

Expand Down
1 change: 1 addition & 0 deletions cmd/loadTestInvokePlugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"github.com/spf13/cobra"
)

// TODO: get rid of global variables, tracking issue: #16
var pluginID string
var pluginInput string

Expand Down
1 change: 1 addition & 0 deletions cmd/loadTestSignVerify.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (

const SIGN_EXAMPLE_DATA string = "0123456789abcdef"

// TODO: get rid of global variables, tracking issue: #16
var signKeyID string
var verifyOpt bool

Expand Down
1 change: 1 addition & 0 deletions cmd/loadTestSymmetricCrypto.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (

const SYM_EXAMPLE_DATA string = "0123456789ABCDEF"

// TODO: get rid of global variables, tracking issue: #16
var keyID string
var decryptOpt bool
var cipherModeStr string
Expand Down
1 change: 1 addition & 0 deletions cmd/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (
"github.com/spf13/cobra"
)

// TODO: get rid of global variables, tracking issue: #16
var serverName string
var serverPort uint16
var insecureTLS bool
Expand Down

0 comments on commit 72d6142

Please sign in to comment.