Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to use rustls 0.22.0-alpha.4 #12

Merged
merged 15 commits into from
Nov 28, 2023
Merged

Conversation

Taowyoo
Copy link
Collaborator

@Taowyoo Taowyoo commented Nov 15, 2023

  • Add impls for SignatureVerificationAlgorithm
  • Upgrade rustls version to 0.22.0-alpha.4
  • Extract common functions to new crate named rustls-mbedtls-provider-utils

@Taowyoo Taowyoo requested a review from s-arash November 15, 2023 01:25
@Taowyoo Taowyoo self-assigned this Nov 15, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (8060fd4) 90.20% compared to head (0b04ace) 94.08%.

Files Patch % Lines
rustls-mbedtls-provider-utils/src/pk.rs 92.24% 9 Missing ⚠️
rustls-mbedcrypto-provider/src/sign.rs 95.13% 7 Missing ⚠️
...s-mbedcrypto-provider/src/signature_verify_algo.rs 94.73% 2 Missing ⚠️
rustls-mbedcrypto-provider/src/kx.rs 66.66% 1 Missing ⚠️
rustls-mbedtls-provider-utils/src/hash.rs 99.16% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   90.20%   94.08%   +3.88%     
==========================================
  Files          11       16       +5     
  Lines        1348     1810     +462     
==========================================
+ Hits         1216     1703     +487     
+ Misses        132      107      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Turn off CARGO_INCREMENTAL to ensure cache & test
coverage works correctly.
Add rustls-mbedtls-provider-utils to default-members
@Taowyoo Taowyoo linked an issue Nov 17, 2023 that may be closed by this pull request
Update `RSA_SIGNATURE_SCHEME_PREFER_LIST` to have a better order.
@Taowyoo Taowyoo requested a review from s-arash November 27, 2023 21:18
@Taowyoo Taowyoo added this pull request to the merge queue Nov 28, 2023
Merged via the queue into master with commit a04c185 Nov 28, 2023
13 checks passed
@Taowyoo Taowyoo deleted the yx/rustls-0.22.0-alpha.4 branch November 29, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade crypto provider to use rustls 0.22.0-alpha.4 when avaialbe
2 participants