Add java example #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taowyoo
force-pushed
the
yx/add-java-example
branch
from
2853cba to
d9f96ac
Compare
xinyufort
reviewed
Sep 5, 2023
...n/java-example/src/main/java/com/fortanix/key_attestation_statement_verification/Common.java
Outdated
Show resolved
Hide resolved
...n/java-example/src/main/java/com/fortanix/key_attestation_statement_verification/Common.java
Outdated
Show resolved
Hide resolved
...n/java-example/src/main/java/com/fortanix/key_attestation_statement_verification/Verify.java
Outdated
Show resolved
Hide resolved
...n/java-example/src/main/java/com/fortanix/key_attestation_statement_verification/Verify.java
Outdated
Show resolved
Hide resolved
...n/java-example/src/main/java/com/fortanix/key_attestation_statement_verification/Verify.java
Outdated
Show resolved
Hide resolved
...com/fortanix/key_attestation_statement_verification/certchecker/FortanixRootCertChecker.java
Outdated
Show resolved
Hide resolved
...fortanix/key_attestation_statement_verification/certchecker/KeyAttestationCaCertChecker.java
Outdated
Show resolved
Hide resolved
xinyufort
reviewed
Sep 6, 2023
There was a problem hiding this comment.
I've left another round of (mostly) nitpicks. Even if you choose to ignore my suggestions, I do hope you at least give my comments a read.
Otherwise, I don't see any red flags at all. (But hey, I'm not a Java pro, so 🤷). Let me know when you want me to take another look and/or approve.
...estation/java-example/src/main/java/com/fortanix/keyattestationstatementverifier/Verify.java
Show resolved
Hide resolved
...estation/java-example/src/main/java/com/fortanix/keyattestationstatementverifier/Verify.java
Outdated
Show resolved
Hide resolved
...estation/java-example/src/main/java/com/fortanix/keyattestationstatementverifier/Verify.java
Outdated
Show resolved
Hide resolved
...estation/java-example/src/main/java/com/fortanix/keyattestationstatementverifier/Verify.java
Show resolved
Hide resolved
...tanix/keyattestationstatementverifier/certchecker/DsmKeyAttestationAuthorityCertChecker.java
Outdated
Show resolved
Hide resolved
...n/java/com/fortanix/keyattestationstatementverifier/types/asn1/NodeEnrollmentPolicyItem.java
Outdated
Show resolved
Hide resolved
...-example/src/main/java/com/fortanix/keyattestationstatementverifier/types/asn1/KeyUsage.java
Outdated
Show resolved
Hide resolved
...in/java/com/fortanix/keyattestationstatementverifier/types/json/KeyAttestationStatement.java
Outdated
Show resolved
Hide resolved
key-attestation/java-example/src/test/resources/key-attestation-response.json
Outdated
Show resolved
Hide resolved
key-attestation/java-example/src/test/resources/key-attestation-statement.pem
Outdated
Show resolved
Hide resolved
xinyufort
reviewed
Sep 6, 2023
...fortanix/keyattestationstatementverifier/certchecker/KeyAttestationStatementCertChecker.java
Outdated
Show resolved
Hide resolved
Since we cannot expect what kind of asymmetric key will be in Key Attestation statement, we can skip the check of public key for now.
xinyufort
approved these changes
Sep 6, 2023
...estation/java-example/src/main/java/com/fortanix/keyattestationstatementverifier/Verify.java
Outdated
Show resolved
Hide resolved
Refactor KeyUsageExt into a bitflags like type
xinyufort
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Oh wow, you actually created a new KeyUsageExt type 😲
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.