Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project logo #40

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Add project logo #40

merged 3 commits into from
Aug 23, 2023

Conversation

cval26
Copy link
Contributor

@cval26 cval26 commented Aug 19, 2023 •
edited by awvwgk
Loading

Closes #23
Closes #24

Creates a media folder containing the logo files and adds logo in the README file.

Thanks to @1984logo for creating and sharing the logo files.

zoziha
zoziha approved these changes Aug 20, 2023
View reviewed changes
Copy link
Contributor

@zoziha zoziha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for FFTPACK logos, @1984logo, @cval26 .

awvwgk
awvwgk approved these changes Aug 20, 2023
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing. Looks good to me.

@cval26
Copy link
Contributor Author

cval26 commented Aug 20, 2023 •
edited
Loading

@zoziha @awvwgk
Should we merge this, or is anything else required?

The two build errors seem to be unrelated to the changes made in this PR.

@cval26 cval26 mentioned this pull request Aug 20, 2023
Closed
@1984logo
Copy link

Thx @cval26 for this PR. I noticed some artifacts in the svg versions (probably due to unnecessary layers). Let me fix that.

@1984logo
Copy link

@cval26 I edited the files (minor technical improvements). Could you replace the PR files in media with the following files?
logo-fftpack-r2.zip.

@cval26
Copy link
Contributor Author

cval26 commented Aug 22, 2023

@1984logo I updated the logos in the media folder.

@zoziha @awvwgk This is ready for merging.

@awvwgk awvwgk merged commit 0e634c6 into fortran-lang:main Aug 23, 2023
7 of 9 checks passed
@cval26 cval26 deleted the logo branch August 29, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoziha zoziha zoziha approved these changes

@awvwgk awvwgk awvwgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logo
4 participants
@cval26 @1984logo @awvwgk @zoziha