Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FButton.icon constructor #121

Closed
Pante opened this issue Jul 25, 2024 · 0 comments · Fixed by #138
Closed

Add FButton.icon constructor #121

Pante opened this issue Jul 25, 2024 · 0 comments · Fixed by #138
Labels
difficulty: easy Trivial tasks that everyone should be able to accomplish. duration: tiny Features that take < 3 man-hours priority: high Requires urgent attention, i.e. those that block progress of other features type: ehancement A new feature or request

Comments

@Pante
Copy link
Member

Pante commented Jul 25, 2024 •
edited
Loading

It'll be nice if there was a constructor for creating a icon button. The current button constructor that accepts a prefix and suffix icon ends up introducing additional padding.

See https://ui.shadcn.com/docs/components/button#icon
@Pante Pante added the type: ehancement A new feature or request label Jul 25, 2024
@Pante Pante added difficulty: easy Trivial tasks that everyone should be able to accomplish. duration: tiny Features that take < 3 man-hours priority: medium Default/Normal priority labels Aug 2, 2024
@Pante Pante added priority: high Requires urgent attention, i.e. those that block progress of other features and removed priority: medium Default/Normal priority labels Aug 2, 2024
@kawaijoe kawaijoe moved this to Todo in Forui Roadmap Aug 2, 2024
@sommye-ctr sommye-ctr mentioned this issue Aug 3, 2024
Merged
4 tasks
@Pante Pante linked a pull request Aug 11, 2024 that will close this issue
Added FButton.icon for a single icon button #138
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in Forui Roadmap Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy Trivial tasks that everyone should be able to accomplish. duration: tiny Features that take < 3 man-hours priority: high Requires urgent attention, i.e. those that block progress of other features type: ehancement A new feature or request
Projects
Forui Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added FButton.icon for a single icon button sommye-ctr/forui
1 participant
@Pante