Added FButton.icon for a single icon button #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pante
force-pushed
the
icon-button
branch
2 times, most recently
from
59f02b3 to
46866a1
Compare
# Conflicts: # forui/lib/src/widgets/divider.dart
Pante
requested changes
Aug 10, 2024
Co-authored-by: Matthias Ngeo <[email protected]>
Co-authored-by: Matthias Ngeo <[email protected]>
Co-authored-by: Matthias Ngeo <[email protected]>
# Conflicts: # forui/lib/src/widgets/button/button.dart
|
Just tried the library today and my first thought was that it is missing basic components such as IconButton 😅 Glad to see that someone has already started working on this. Any chances to push this new component soon? |
Pante
requested changes
Aug 13, 2024
Pante
requested changes
Aug 15, 2024
Pante
had a problem deploying
to
docs-development
GitHub Actions
Failure
Pante
had a problem deploying
to
docs-development
GitHub Actions
Failure
|
Seems like there was a bug with our workflows which built code on the base branch instead of the head. I've updated the actions accordingly. |
# Conflicts: # forui/lib/src/widgets/button/button.dart
sommye-ctr
had a problem deploying
to
docs-development
GitHub Actions
Failure
sommye-ctr
temporarily deployed
to
docs-development
GitHub Actions
Inactive
Pante
reviewed
Aug 16, 2024
sommye-ctr
temporarily deployed
to
docs-development
GitHub Actions
Inactive
|
LGTM! Thanks for the contribution. |
Pante
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
This adds a
FButton.iconconstructor which will be used to create buttons having a single icon as their content.Resolves #121
Checklist