Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce FIcon #210

Merged
merged 8 commits into from
Oct 3, 2024
Merged

Introduce FIcon #210

merged 8 commits into from
Oct 3, 2024

Conversation

Pante
Copy link
Member

@Pante Pante commented Oct 1, 2024

Describe the changes
This PR introduces FIcon, a generic replacement of all custom F<Widget>Icon, such as FAlertIcon and FButtonIcon. It also tidies up the weird hierarchy in FButtonCustomStyle.

Checklist

  • I have read the CONTRIBUTING.md.
  • I have included the relevant unit/golden tests.
  • I have included the relevant samples.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG.md if necessary.

@Pante Pante temporarily deployed to docs-development October 1, 2024 11:27 — with GitHub Actions Inactive
@auto-maid
Copy link

auto-maid bot commented Oct 1, 2024

Documentation Preview

Latest Commit SHA d8da1d2
Preview URL https://12704484.forui-docs-dev.pages.dev/docs

You're seeing this because the docs/samples were updated.

@Pante Pante temporarily deployed to docs-development October 2, 2024 13:51 — with GitHub Actions Inactive
@Pante Pante marked this pull request as ready for review October 2, 2024 13:53
@Pante Pante temporarily deployed to docs-development October 2, 2024 13:55 — with GitHub Actions Inactive
@auto-maid auto-maid bot temporarily deployed to docs-development October 2, 2024 13:56 Inactive
@Pante Pante temporarily deployed to docs-development October 2, 2024 14:01 — with GitHub Actions Inactive
@auto-maid auto-maid bot temporarily deployed to docs-development October 2, 2024 14:02 Inactive
docs/pages/docs/icon.mdx Outdated Show resolved Hide resolved
docs/pages/docs/icon.mdx Show resolved Hide resolved
docs/pages/docs/icon.mdx Outdated Show resolved Hide resolved
forui/lib/src/widgets/icon.dart Show resolved Hide resolved
forui/lib/src/widgets/icon.dart Show resolved Hide resolved
forui/lib/src/widgets/icon.dart Show resolved Hide resolved
forui/lib/src/widgets/icon.dart Show resolved Hide resolved
@Pante Pante had a problem deploying to docs-development October 3, 2024 09:48 — with GitHub Actions Failure
@Pante Pante temporarily deployed to docs-development October 3, 2024 09:51 — with GitHub Actions Inactive
@Pante Pante merged commit 357dfe5 into main Oct 3, 2024
11 checks passed
@Pante Pante deleted the feature/icon branch October 3, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants