Fix select group not applying correct style #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation Preview
You're seeing this because the docs/samples were updated. |
kawaijoe
reviewed
Oct 5, 2024
Daviiddoo
approved these changes
Oct 6, 2024
Pante
force-pushed
the
fix/select-group
branch
from
c7e64d0 to
ad363b6
Compare
Pante
had a problem deploying
to
docs-development
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
This PR fixes select group not applying correct style. It also refactors FSelectGroupItem to use classes instead of functions, following the guidance in https://stackoverflow.com/a/53234826/4189771. Lastly, it introduces the concept of "blue screen" testing to verify that custom styles are applied correctly.
Checklist