Fix popover parameter name

docs/pages/docs/overlay/popover-menu.mdx

@@ -92,7 +92,7 @@ const FPopoverMenu(
   controller: FPopoverController(),
   menuAnchor: Alignment.topCenter,
   childAnchor: Alignment.bottomCenter,
-  ignoreDirectionalPadding: true,
+  directionPadding: false,
   hideOnTapOutside: true,
   shift: FPortalFollowerShift.flip,
   menu: [
@@ -111,7 +111,7 @@ const FPopoverMenu.tappable(
   controller: FPopoverController(),
   menuAnchor: Alignment.topCenter,
   childAnchor: Alignment.bottomCenter,
-  ignoreDirectionalPadding: true,
+  directionPadding: false,
   hideOnTapOutside: true,
   shift: FPortalFollowerShift.flip,
   menu: [

docs/pages/docs/overlay/popover.mdx

@@ -97,7 +97,7 @@ const FPopover(
   controller: FPopoverController(),
   followerAnchor: Alignment.topCenter,
   targetAnchor: Alignment.bottomCenter,
-  ignoreDirectionalPadding: true,
+  directionPadding: false,
   hideOnTapOutside: true,
   shift: FPortalFollowerShift.flip,
   follower: (context) => const Placeholder(),
@@ -112,7 +112,7 @@ const FPopover.tappable(
   controller: FPopoverController(),
   followerAnchor: Alignment.topCenter,
   targetAnchor: Alignment.bottomCenter,
-  ignoreDirectionalPadding: true,
+  directionPadding: false,
   hideOnTapOutside: true,
   shift: FPortalFollowerShift.flip,
   follower: (context) => const Placeholder(),

forui/CHANGELOG.md

@@ -1,4 +1,15 @@
-## 0.7.0 (Next)
+## 0.8.0 (Next)
+
+### Changes
+
+* **Breaking** Change `Popover.ignoreDirectionalPadding` to `Popover.directionPadding` - the value should be inverted.
+
+* **Breaking** Change `PopoverMenu.ignoreDirectionalPadding` to `PopoverMenu.directionPadding` - the value should be inverted.
+
+* **Breaking** Change `SelectMenuTile.ignoreDirectionalPadding` to `SelectMenuTile.directionPadding` - the value should be inverted.
+
+
+## 0.7.0
 
 This update adds responsive breakpoints, focused outlines & localization! It also introduces several new tile widgets.
 

forui/lib/src/foundation/rendering.dart

@@ -29,7 +29,7 @@ extension RenderBoxes on RenderBox {
 
 @internal
 extension Alignments on Alignment {
-  static Offset ignoreDirectionalPadding(EdgeInsets padding, Alignment follower, Alignment target) {
+  static Offset removeDirectionalPadding(EdgeInsets padding, Alignment follower, Alignment target) {
     final Alignment(:x, :y) = follower;
     // ignore corners that are diagonal.
     if (x != 0 && y != 0 && x == -target.x && y == -target.y) {

forui/lib/src/widgets/popover.dart

@@ -100,10 +100,10 @@ class FPopover extends StatefulWidget {
   /// True if the popover is hidden when tapped outside of it. Defaults to true.
   final bool hideOnTapOutside;
 
-  /// True if the follower should ignore the cross-axis padding of the anchor when aligning to it. Defaults to true.
+  /// True if the follower should include the cross-axis padding of the anchor when aligning to it. Defaults to false.
   ///
   /// Diagonal corners are ignored.
-  final bool ignoreDirectionalPadding;
+  final bool directionPadding;
 
   /// The follower's semantic label used by accessibility frameworks.
   final String? semanticLabel;
@@ -148,7 +148,7 @@ class FPopover extends StatefulWidget {
     this.style,
     this.shift = FPortalFollowerShift.flip,
     this.hideOnTapOutside = true,
-    this.ignoreDirectionalPadding = true,
+    this.directionPadding = false,
     this.semanticLabel,
     this.autofocus = false,
     this.focusNode,
@@ -171,7 +171,7 @@ class FPopover extends StatefulWidget {
     this.style,
     this.shift = FPortalFollowerShift.flip,
     this.hideOnTapOutside = true,
-    this.ignoreDirectionalPadding = true,
+    this.directionPadding = false,
     this.semanticLabel,
     this.autofocus = false,
     this.focusNode,
@@ -196,13 +196,7 @@ class FPopover extends StatefulWidget {
       ..add(DiagnosticsProperty('targetAnchor', targetAnchor))
       ..add(DiagnosticsProperty('shift', shift))
       ..add(FlagProperty('hideOnTapOutside', value: hideOnTapOutside, ifTrue: 'hideOnTapOutside'))
-      ..add(
-        FlagProperty(
-          'ignoreDirectionalPadding',
-          value: ignoreDirectionalPadding,
-          ifTrue: 'ignoreDirectionalPadding',
-        ),
-      )
+      ..add(FlagProperty('directionPadding', value: directionPadding, ifTrue: 'directionPadding'))
       ..add(StringProperty('semanticLabel', semanticLabel))
       ..add(FlagProperty('autofocus', value: autofocus, ifTrue: 'autofocus'))
       ..add(DiagnosticsProperty('focusNode', focusNode))
@@ -245,9 +239,8 @@ class _State extends State<FPopover> with SingleTickerProviderStateMixin {
       followerAnchor: widget.followerAnchor,
       targetAnchor: widget.targetAnchor,
       shift: widget.shift,
-      offset: widget.ignoreDirectionalPadding
-          ? Alignments.ignoreDirectionalPadding(style.padding, follower, target)
-          : Offset.zero,
+      offset:
+          widget.directionPadding ? Offset.zero : Alignments.removeDirectionalPadding(style.padding, follower, target),
       followerBuilder: (context) => CallbackShortcuts(
         bindings: {
           const SingleActivator(LogicalKeyboardKey.escape): _controller.hide,

forui/lib/src/widgets/popover_menu.dart

@@ -39,10 +39,10 @@ class FPopoverMenu extends StatefulWidget {
   /// True if the popover is hidden when tapped outside of it. Defaults to true.
   final bool hideOnTapOutside;
 
-  /// True if the menu should ignore the cross-axis padding of the anchor when aligning to it. Defaults to true.
+  /// True if the follower should include the cross-axis padding of the anchor when aligning to it. Defaults to false.
   ///
   /// Diagonal corners are ignored.
-  final bool ignoreDirectionalPadding;
+  final bool directionPadding;
 
   /// The menu's semantic label used by accessibility frameworks.
   final String? semanticLabel;
@@ -90,7 +90,7 @@ class FPopoverMenu extends StatefulWidget {
     this.childAnchor = Alignment.bottomCenter,
     this.shift = FPortalFollowerShift.flip,
     this.hideOnTapOutside = true,
-    this.ignoreDirectionalPadding = true,
+    this.directionPadding = false,
     this.semanticLabel,
     this.autofocus = false,
     this.focusNode,
@@ -112,7 +112,7 @@ class FPopoverMenu extends StatefulWidget {
     this.childAnchor = Alignment.bottomCenter,
     this.shift = FPortalFollowerShift.flip,
     this.hideOnTapOutside = true,
-    this.ignoreDirectionalPadding = true,
+    this.directionPadding = false,
     this.semanticLabel,
     this.autofocus = false,
     this.focusNode,
@@ -134,13 +134,7 @@ class FPopoverMenu extends StatefulWidget {
       ..add(DiagnosticsProperty('childAnchor', childAnchor))
       ..add(DiagnosticsProperty('shift', shift))
       ..add(FlagProperty('hideOnTapOutside', value: hideOnTapOutside, ifTrue: 'hideOnTapOutside'))
-      ..add(
-        FlagProperty(
-          'ignoreDirectionalPadding',
-          value: ignoreDirectionalPadding,
-          ifTrue: 'ignoreDirectionalPadding',
-        ),
-      )
+      ..add(FlagProperty('directionPadding', value: directionPadding, ifTrue: 'directionPadding'))
       ..add(StringProperty('semanticLabel', semanticLabel))
       ..add(FlagProperty('autofocus', value: autofocus, ifTrue: 'autofocus'))
       ..add(DiagnosticsProperty('focusNode', focusNode))
@@ -180,7 +174,7 @@ class _FPopoverMenuState extends State<FPopoverMenu> with SingleTickerProviderSt
       targetAnchor: widget.childAnchor,
       shift: widget.shift,
       hideOnTapOutside: widget.hideOnTapOutside,
-      ignoreDirectionalPadding: widget.ignoreDirectionalPadding,
+      directionPadding: widget.directionPadding,
       autofocus: widget.autofocus,
       focusNode: widget.focusNode,
       onFocusChange: widget.onFocusChange,

forui/lib/src/widgets/select_menu_tile.dart

@@ -52,10 +52,10 @@ class FSelectMenuTile<T> extends FormField<Set<T>> with FTileMixin {
   /// True if the popover is hidden when tapped outside of it. Defaults to true.
   final bool hideOnTapOutside;
 
-  /// True if the menu should ignore the cross-axis padding of the anchor when aligning to it. Defaults to true.
+  /// True if the follower should include the cross-axis padding of the anchor when aligning to it. Defaults to false.
   ///
   /// Diagonal corners are ignored.
-  final bool ignoreDirectionalPadding;
+  final bool directionPadding;
 
   /// True if the menu should be automatically hidden after a menu option is selected. Defaults to false.
   final bool autoHide;
@@ -126,7 +126,7 @@ class FSelectMenuTile<T> extends FormField<Set<T>> with FTileMixin {
     this.tileAnchor = Alignment.bottomRight,
     this.shift = FPortalFollowerShift.flip,
     this.hideOnTapOutside = true,
-    this.ignoreDirectionalPadding = true,
+    this.directionPadding = false,
     this.autoHide = false,
     this.label,
     this.description,
@@ -180,7 +180,7 @@ class FSelectMenuTile<T> extends FormField<Set<T>> with FTileMixin {
               targetAnchor: tileAnchor,
               shift: shift,
               hideOnTapOutside: hideOnTapOutside,
-              ignoreDirectionalPadding: ignoreDirectionalPadding,
+              directionPadding: directionPadding,
               autofocus: autofocus,
               focusNode: focusNode,
               onFocusChange: onFocusChange,
@@ -237,13 +237,7 @@ class FSelectMenuTile<T> extends FormField<Set<T>> with FTileMixin {
       ..add(DiagnosticsProperty('tileAnchor', tileAnchor))
       ..add(DiagnosticsProperty('shift', shift))
       ..add(FlagProperty('hideOnTapOutside', value: hideOnTapOutside, ifTrue: 'hideOnTapOutside'))
-      ..add(
-        FlagProperty(
-          'ignoreDirectionalPadding',
-          value: ignoreDirectionalPadding,
-          ifTrue: 'ignoreDirectionalPadding',
-        ),
-      )
+      ..add(FlagProperty('directionPadding', value: directionPadding, ifTrue: 'directionPadding'))
       ..add(FlagProperty('autoHide', value: autoHide, ifTrue: 'autoHide'))
       ..add(ObjectFlagProperty.has('errorBuilder', errorBuilder))
       ..add(StringProperty('semanticLabel', semanticLabel))

forui/test/src/foundation/focused_outline_golden_test.dart

@@ -9,7 +9,7 @@ import 'package:forui/forui.dart';
 import '../test_scaffold.dart';
 
 void main() {
-  group('FAccordion', () {
+  group('FFocusedOutline', () {
     testWidgets('blue screen', (tester) async {
       await tester.pumpWidget(
         TestScaffold.blue(

forui/test/src/foundation/rendering_test.dart

@@ -100,8 +100,8 @@ void main() {
       (Alignment.bottomRight, Alignment.bottomRight, const Offset(3, 4)),
     ]) {
       test(
-        'ignoreDirectionalPadding - $follower - $target',
-        () => expect(Alignments.ignoreDirectionalPadding(insets, follower, target), expected),
+        'removeDirectionalPadding - $follower - $target',
+        () => expect(Alignments.removeDirectionalPadding(insets, follower, target), expected),
       );
     }
 

forui/test/src/widgets/popover/popover_golden_test.dart

@@ -98,7 +98,7 @@ void main() {
             child: FPopover(
               followerAnchor: Alignment.topRight,
               targetAnchor: Alignment.bottomRight,
-              ignoreDirectionalPadding: false,
+              directionPadding: true,
               style: theme.data.popoverStyle.copyWith(padding: const EdgeInsets.all(50)),
               controller: controller,
               followerBuilder: (context, style, _) => const SizedBox.square(dimension: 100),
@@ -121,7 +121,7 @@ void main() {
         );
       });
 
-      testWidgets('${theme.name} ignore directional padding', (tester) async {
+      testWidgets('${theme.name} no directional padding', (tester) async {
         await tester.pumpWidget(
           TestScaffold.app(
             theme: theme.data,
@@ -146,7 +146,7 @@ void main() {
 
         await expectLater(
           find.byType(TestScaffold),
-          matchesGoldenFile('popover/ignore-directional-padding-${theme.name}.png'),
+          matchesGoldenFile('popover/no-directional-padding-${theme.name}.png'),
         );
       });
     });

forui/test/src/widgets/popover_menu/popover_menu_golden_test.dart

@@ -101,7 +101,7 @@ void main() {
             child: FPopoverMenu(
               menuAnchor: Alignment.topRight,
               childAnchor: Alignment.bottomRight,
-              ignoreDirectionalPadding: false,
+              directionPadding: true,
               style: theme.data.popoverMenuStyle.copyWith(padding: const EdgeInsets.all(50)),
               controller: controller,
               menu: [
@@ -141,7 +141,7 @@ void main() {
         );
       });
 
-      testWidgets('${theme.name} ignore directional padding', (tester) async {
+      testWidgets('${theme.name} without no directional padding', (tester) async {
         await tester.pumpWidget(
           TestScaffold.app(
             theme: theme.data,
@@ -183,7 +183,7 @@ void main() {
 
         await expectLater(
           find.byType(TestScaffold),
-          matchesGoldenFile('popover-menu/ignore-directional-padding-${theme.name}.png'),
+          matchesGoldenFile('popover-menu/no-directional-padding-${theme.name}.png'),
         );
       });
     });