Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sheet #282

Merged
merged 29 commits into from
Dec 8, 2024
Merged

Add sheet #282

merged 29 commits into from
Dec 8, 2024

Conversation

Pante
Copy link
Member

@Pante Pante commented Nov 20, 2024

Describe the changes
This PR adds modal & persistent sheets. It resolves #42.

Checklist

  • I have read the CONTRIBUTING.md.
  • I have included the relevant unit/golden tests.
  • I have included the relevant samples.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG.md if necessary.

@Pante Pante force-pushed the feature/sheet branch 2 times, most recently from b76c764 to eac47cb Compare November 26, 2024 07:59
@Pante Pante temporarily deployed to docs-development November 29, 2024 09:34 — with GitHub Actions Inactive
@Pante Pante marked this pull request as ready for review November 29, 2024 09:34
@Pante Pante temporarily deployed to docs-development November 29, 2024 09:36 — with GitHub Actions Inactive
@auto-maid
Copy link

auto-maid bot commented Nov 29, 2024

Documentation Preview

Latest Commit SHA 898acdb
Preview URL https://b183d758.forui-docs-dev.pages.dev/docs

You're seeing this because the docs/samples were updated.

@auto-maid auto-maid bot temporarily deployed to docs-development November 29, 2024 09:38 Inactive
@Pante Pante requested a review from kawaijoe November 29, 2024 09:39
@Pante Pante self-assigned this Dec 1, 2024
@Pante Pante marked this pull request as draft December 3, 2024 02:25
@Pante Pante changed the title Add modal sheet Add sheet Dec 3, 2024
@Pante Pante temporarily deployed to docs-development December 5, 2024 06:48 — with GitHub Actions Inactive
@Pante Pante temporarily deployed to docs-development December 5, 2024 07:00 — with GitHub Actions Inactive
@Pante Pante marked this pull request as ready for review December 5, 2024 07:01
@kawaijoe
Copy link
Member

kawaijoe commented Dec 6, 2024

While not a bug with the sheet per se, I think it could be nice if we only allowed one sheet to show at a time.

Screen.Recording.2024-12-06.at.10.02.33.PM.mp4

@auto-maid auto-maid bot temporarily deployed to docs-development December 7, 2024 07:53 Inactive
@Pante Pante mentioned this pull request Dec 8, 2024
5 tasks
forui/lib/src/widgets/sheet/modal_sheet.dart Outdated Show resolved Hide resolved
docs/pages/docs/overlay/_meta.ts Outdated Show resolved Hide resolved
docs/pages/docs/overlay/modal-sheet.mdx Outdated Show resolved Hide resolved
docs/pages/docs/overlay/modal-sheet.mdx Outdated Show resolved Hide resolved
docs/pages/docs/overlay/persistent-sheet.mdx Outdated Show resolved Hide resolved
docs/pages/docs/overlay/persistent-sheet.mdx Outdated Show resolved Hide resolved
docs/pages/docs/overlay/persistent-sheet.mdx Show resolved Hide resolved
forui/lib/src/widgets/sheet/modal_sheet.dart Show resolved Hide resolved
forui/lib/src/widgets/sheet/persistent_sheet.dart Outdated Show resolved Hide resolved
docs/pages/docs/overlay/modal-sheet.mdx Outdated Show resolved Hide resolved
@Pante Pante temporarily deployed to docs-development December 8, 2024 10:28 — with GitHub Actions Inactive
@auto-maid auto-maid bot temporarily deployed to docs-development December 8, 2024 10:29 Inactive
@Pante Pante temporarily deployed to docs-development December 8, 2024 13:16 — with GitHub Actions Inactive
@auto-maid auto-maid bot temporarily deployed to docs-development December 8, 2024 13:18 Inactive
forui/lib/src/widgets/sheet/modal_sheet.dart Outdated Show resolved Hide resolved
@Pante Pante temporarily deployed to docs-development December 8, 2024 14:51 — with GitHub Actions Inactive
@Pante Pante temporarily deployed to docs-development December 8, 2024 14:53 — with GitHub Actions Inactive
@auto-maid auto-maid bot temporarily deployed to docs-development December 8, 2024 14:54 Inactive
@Pante Pante merged commit 9b7b97a into main Dec 8, 2024
12 checks passed
@Pante Pante deleted the feature/sheet branch December 8, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sheet
2 participants