Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resizeToAvoidBottomInset parameter in FScaffold #304

Merged
merged 12 commits into from
Dec 13, 2024

Conversation

kawaijoe
Copy link
Member

@kawaijoe kawaijoe commented Dec 7, 2024

Describe the changes
Fixes #293

Checklist

  • I have read the CONTRIBUTING.md.
  • I have included the relevant unit/golden tests.
  • I have included the relevant samples.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG.md if necessary.

@kawaijoe kawaijoe self-assigned this Dec 8, 2024
@kawaijoe kawaijoe requested a review from Pante December 13, 2024 09:00
@kawaijoe kawaijoe marked this pull request as ready for review December 13, 2024 09:00
@auto-maid
Copy link

auto-maid bot commented Dec 13, 2024

Documentation Preview

Latest Commit SHA c33d42d
Preview URL https://c19eafda.forui-docs-dev.pages.dev/docs

You're seeing this because the docs/samples were updated.

@auto-maid auto-maid bot temporarily deployed to docs-development December 13, 2024 09:24 Inactive
@Pante Pante requested a review from Copilot December 13, 2024 13:46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • .idea/runConfigurations/Run_Samples_build_runner.xml: Language not supported
  • docs/pages/docs/layout/scaffold.mdx: Language not supported
  • forui/example/.gitignore: Language not supported
  • forui/example/lib/sandbox.dart: Language not supported
  • forui/lib/src/widgets/scaffold.dart: Language not supported
  • forui/test/src/widgets/scaffold_golden_test.dart: Language not supported
Copy link
Member

@Pante Pante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, just some minor nits.

forui/lib/src/widgets/scaffold.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/scaffold.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/scaffold.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/scaffold.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/scaffold.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/scaffold.dart Outdated Show resolved Hide resolved
@kawaijoe kawaijoe force-pushed the fix/scaffold-avoid-bottom-inset branch from a8a17eb to c33d42d Compare December 13, 2024 14:42
@kawaijoe kawaijoe merged commit 12d8d75 into main Dec 13, 2024
11 checks passed
@kawaijoe kawaijoe deleted the fix/scaffold-avoid-bottom-inset branch December 13, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FScaffold resizeToAvoidBottomInset
2 participants