Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs #44

Merged
merged 33 commits into from
Jun 24, 2024
Merged

Tabs #44

merged 33 commits into from
Jun 24, 2024

Conversation

Daviiddoo
Copy link
Contributor

No description provided.

@Daviiddoo Daviiddoo marked this pull request as ready for review June 18, 2024 10:38
@Daviiddoo Daviiddoo requested a review from Pante June 18, 2024 10:38
Copy link
Member

@Pante Pante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to end the review early as there are far too many minor/style issues littered throughout the PR to individually go through.

The documentation for certain classes is inconsistent with the rest of the classes/grammatically incorrect. For example, An object that represents a tab entry in a group of tabs.. We usually don't start a description with "An object that represents ..." since it's redundant can be shorten.

When in doubt, please reference the other Forui widgets or Flutter Material documentation.

In other cases, the documentation is copy-pasted (which is perfectly okay), but still references the class which it was copied from.

I'm going to mark this as a draft PR for now. Please go through the PR and fix the styling & documentation issues.

forui/lib/src/theme/theme_data.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/tabs/tab_controller.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/tabs/tab_controller.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/tabs/tab_controller.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/tabs/tab_controller.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/tabs/tabs.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/tabs/tabs.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/tabs/tabs.dart Show resolved Hide resolved
forui/lib/src/widgets/tabs/tabs.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/tabs/tabs.dart Outdated Show resolved Hide resolved
@Pante Pante marked this pull request as draft June 19, 2024 13:09
@Daviiddoo Daviiddoo marked this pull request as ready for review June 19, 2024 16:58
@Daviiddoo Daviiddoo requested a review from Pante June 19, 2024 17:51
Copy link
Member

@Pante Pante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for `FTabEntry

forui/lib/src/widgets/tabs/tab_controller.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/tabs/tabs.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/tabs/tabs.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/tabs/tabs.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/tabs/tabs.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/tabs/tabs.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/tabs/tabs.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/tabs/tabs_style.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/tabs/tabs_style.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/tabs/tabs.dart Outdated Show resolved Hide resolved
@Daviiddoo Daviiddoo requested a review from Pante June 23, 2024 14:30
forui/lib/src/widgets/tabs/tabs.dart Outdated Show resolved Hide resolved
@Daviiddoo Daviiddoo merged commit a7410c1 into master Jun 24, 2024
5 checks passed
@Daviiddoo Daviiddoo deleted the feature/tabs branch June 24, 2024 07:33
@Daviiddoo Daviiddoo mentioned this pull request Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants