-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs #44
Tabs #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to end the review early as there are far too many minor/style issues littered throughout the PR to individually go through.
The documentation for certain classes is inconsistent with the rest of the classes/grammatically incorrect. For example, An object that represents a tab entry in a group of tabs.
. We usually don't start a description with "An object that represents ..." since it's redundant can be shorten.
When in doubt, please reference the other Forui widgets or Flutter Material documentation.
In other cases, the documentation is copy-pasted (which is perfectly okay), but still references the class which it was copied from.
I'm going to mark this as a draft PR for now. Please go through the PR and fix the styling & documentation issues.
…i expose to the user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests for `FTabEntry
Co-authored-by: Matthias Ngeo <[email protected]>
Co-authored-by: Matthias Ngeo <[email protected]>
Co-authored-by: Matthias Ngeo <[email protected]>
Co-authored-by: Matthias Ngeo <[email protected]>
…to feature/tabs
No description provided.