Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested header #57

Merged
merged 16 commits into from
Jun 30, 2024
Merged

Nested header #57

merged 16 commits into from
Jun 30, 2024

Conversation

kawaijoe
Copy link
Member

@kawaijoe kawaijoe commented Jun 27, 2024

Resolves #56
Removed generate golden test run configuration
Add samples run with default port of 3001

@kawaijoe kawaijoe self-assigned this Jun 27, 2024
@kawaijoe kawaijoe requested a review from Pante June 27, 2024 16:05
@kawaijoe kawaijoe marked this pull request as ready for review June 27, 2024 16:05
@kawaijoe kawaijoe force-pushed the feature/nested-header branch from ff57b56 to e79cdba Compare June 29, 2024 08:20
forui/lib/src/theme/theme_data.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/header/header.dart Show resolved Hide resolved
forui/lib/src/widgets/header/header.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/header/header.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/header/header.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/header/root_header.dart Show resolved Hide resolved
forui/lib/src/widgets/header/root_header.dart Show resolved Hide resolved
forui/lib/src/widgets/header/root_header.dart Show resolved Hide resolved
forui/lib/src/widgets/header/root_header.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/header/root_header.dart Show resolved Hide resolved
Copy link
Member

@Pante Pante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammatical errors in the documentation, other than that LGTM. Feel free to merge after fixing them.

forui/lib/src/widgets/header/header.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/header/header.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/header/header.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/header/header.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/header/nested_header.dart Outdated Show resolved Hide resolved
@kawaijoe kawaijoe merged commit 9d1c341 into main Jun 30, 2024
6 checks passed
@kawaijoe kawaijoe deleted the feature/nested-header branch June 30, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested header
2 participants