Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed raw parameters #68

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Removed raw parameters #68

merged 5 commits into from
Jul 2, 2024

Conversation

kawaijoe
Copy link
Member

@kawaijoe kawaijoe commented Jul 1, 2024 •
edited
Loading

Resolves #67

@kawaijoe kawaijoe requested a review from Pante July 1, 2024 15:31
@kawaijoe kawaijoe self-assigned this Jul 1, 2024
Pante
Pante requested changes Jul 1, 2024
View reviewed changes
Copy link
Member

@Pante Pante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor stuff. Other than that LGTM. Feel free to merge after fixing!

forui/lib/src/widgets/badge/badge_content.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/button/button.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/card/card.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/card/card_content.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/button/button_content.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/button/button_content.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/dialog/dialog_content.dart Outdated Show resolved Hide resolved
forui/lib/src/widgets/dialog/dialog_content.dart Outdated Show resolved Hide resolved
@kawaijoe kawaijoe merged commit 1a25474 into main Jul 2, 2024
6 checks passed
@kawaijoe kawaijoe deleted the fix/refactor-text branch July 2, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pante Pante Pante requested changes

Assignees

@kawaijoe kawaijoe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove raw parameters
2 participants
@kawaijoe @Pante