Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototype theme foundations #9

Merged
merged 27 commits into from
May 9, 2024
Merged

Prototype theme foundations #9

merged 27 commits into from
May 9, 2024

Conversation

kawaijoe
Copy link
Member

@kawaijoe kawaijoe commented May 7, 2024

This PR lays the foundation of how FTheme should work.

@kawaijoe kawaijoe added difficulty: hard duration: medium Features tha take ~2-3 man-days priority: high Requires urgent attention, i.e. those that block progress of other features type: ehancement A new feature or request labels May 7, 2024
@kawaijoe kawaijoe requested a review from Pante May 7, 2024 09:32
@kawaijoe kawaijoe self-assigned this May 7, 2024
@kawaijoe kawaijoe marked this pull request as ready for review May 9, 2024 03:23
Pante
Pante requested changes May 9, 2024
View reviewed changes
Copy link
Member

@Pante Pante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the layout of the widgets is good, the documentation just needs to be revised slightly.

forui/lib/src/box/box.dart Outdated Show resolved Hide resolved
forui/lib/src/box/box_style.dart Outdated Show resolved Hide resolved
forui/lib/src/box/box_style.dart Outdated Show resolved Hide resolved
forui/lib/src/theme/font/font_data.dart Outdated Show resolved Hide resolved
forui/lib/src/theme/font/font_data.dart Outdated Show resolved Hide resolved
forui/lib/src/theme/style/zinc_style.dart Outdated Show resolved Hide resolved
forui/lib/src/theme/style/zinc_style.dart Outdated Show resolved Hide resolved
forui/lib/src/theme/style_data.dart Outdated Show resolved Hide resolved
forui/lib/src/theme/theme_data.dart Outdated Show resolved Hide resolved
forui/lib/src/theme/widget_data.dart Outdated Show resolved Hide resolved
kawaijoe and others added 15 commits May 9, 2024 14:00
@kawaijoe @Pante
Update forui/lib/src/box/box.dart
946a655 
Co-authored-by: Matthias Ngeo <[email protected]>
@kawaijoe @Pante
Update forui/lib/src/box/box_style.dart
ed33064 
Co-authored-by: Matthias Ngeo <[email protected]>
@kawaijoe @Pante
Update forui/lib/src/box/box_style.dart
c5f3b50 
Co-authored-by: Matthias Ngeo <[email protected]>
@kawaijoe @Pante
Update forui/lib/src/theme/font/font_data.dart
f4cd690 
Co-authored-by: Matthias Ngeo <[email protected]>
@kawaijoe @Pante
Update forui/lib/src/theme/font/text_style_builder.dart
61d540c 
Co-authored-by: Matthias Ngeo <[email protected]>
@kawaijoe @Pante
Update forui/lib/src/theme/font/text_style_builder.dart
83e99d6 
Co-authored-by: Matthias Ngeo <[email protected]>
@kawaijoe @Pante
Update forui/lib/src/theme/font/text_style_builder.dart
032f5eb 
Co-authored-by: Matthias Ngeo <[email protected]>
@kawaijoe @Pante
Update forui/lib/src/theme/style_data.dart
380d824 
Co-authored-by: Matthias Ngeo <[email protected]>
@kawaijoe @Pante
Update forui/lib/src/theme/style/zinc_style.dart
25034a9 
Co-authored-by: Matthias Ngeo <[email protected]>
@kawaijoe @Pante
Update forui/lib/src/theme/theme_data.dart
9471a04 
Co-authored-by: Matthias Ngeo <[email protected]>
@kawaijoe @Pante
Update forui/lib/src/theme/widget_data.dart
0c9a2fd 
Co-authored-by: Matthias Ngeo <[email protected]>
@kawaijoe
Commit from GitHub Actions (Forui Presubmit)
5738bf8
@kawaijoe @Pante
Update forui/lib/src/theme/style/zinc_style.dart
fc7a36a 
Co-authored-by: Matthias Ngeo <[email protected]>
@kawaijoe
Commit from GitHub Actions (Forui Presubmit)
6754c0a
@kawaijoe
Fix PR issues
be0db55
Pante
Pante requested changes May 9, 2024
View reviewed changes
Copy link
Member

@Pante Pante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few documentation changes, other than that LGTM.

forui/lib/src/theme/font/font_data.dart Outdated Show resolved Hide resolved
@Pante Pante merged commit 903881c into master May 9, 2024
4 of 5 checks passed
@Pante Pante deleted the feature/foundation branch May 9, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pante Pante Pante approved these changes

Assignees

@kawaijoe kawaijoe

Labels
difficulty: hard duration: medium Features tha take ~2-3 man-days priority: high Requires urgent attention, i.e. those that block progress of other features type: ehancement A new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kawaijoe @Pante