Merge pull request #28 from forward3d/upgrade-13

Upgrade V13
forward3d · Dec 2, 2019 · e9318cd · e9318cd
2 parents 728c4a3 + fa35db3
commit e9318cd
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 129 deletions.
diff --git a/CHANGELOG.txt b/CHANGELOG.txt
@@ -1,3 +1,7 @@
+* 5.0.0
+  Fully using API V13
+  BREAKING CHANGE: AdInsightService class removed, use ReportingService instead
+
 * 4.2.0
   Add InsightService request class for custom reports.
 

diff --git a/lib/bing-ads-reporting/ad_insight_service.rb b/lib/bing-ads-reporting/ad_insight_service.rb
diff --git a/lib/bing-ads-reporting/bulk_service.rb b/lib/bing-ads-reporting/bulk_service.rb
@@ -2,7 +2,7 @@
 
 module BingAdsReporting
   class BulkService < ServiceCore
-    WDSL = 'https://bulk.api.bingads.microsoft.com/Api/Advertiser/CampaignManagement/V12/BulkService.svc?wsdl'.freeze
+    WDSL = 'https://bulk.api.bingads.microsoft.com/Api/Advertiser/CampaignManagement/V13/BulkService.svc?wsdl'.freeze
     FAILED_STATUS = 'Failed'.freeze
     SUCCESS_STATUS = 'Completed'.freeze
 
@@ -33,8 +33,6 @@ def generate_report_message(options)
       data_scope = options[:data_scope]
 
       message = report_message(options, data_scope)
-      message = message_data_scope(message, period) if data_scope == 'EntityPerformanceData'
-      # end
       message
     end
 
@@ -50,14 +48,6 @@ def report_message(options, data_scope)
       }
     end
 
-    def message_data_scope(message)
-      message[ns('PerformanceStatsDateRange')] = {
-        # apparently order is important, and end date has to be before start date, wtf
-        ns('CustomDateRangeEnd') => scope_data_range(period.to),
-        ns('CustomDateRangeStart') => scope_data_range(period.from)
-      }
-    end
-
     def scope_data_range(period_range)
       day_key = ns('Day')
       month_key = ns('Month')

diff --git a/lib/bing-ads-reporting/reporting_service.rb b/lib/bing-ads-reporting/reporting_service.rb
@@ -2,7 +2,7 @@
 
 module BingAdsReporting
   class ReportingService < ServiceCore
-    WDSL = 'https://reporting.api.bingads.microsoft.com/Api/Advertiser/Reporting/V12/ReportingService.svc?singleWsdl'.freeze
+    WDSL = 'https://reporting.api.bingads.microsoft.com/Api/Advertiser/Reporting/V13/ReportingService.svc?singleWsdl'.freeze
     FAILED_STATUS = 'Error'.freeze
     SUCCESS_STATUS = 'Success'.freeze
 

diff --git a/lib/bing-ads-reporting/version.rb b/lib/bing-ads-reporting/version.rb
@@ -1,3 +1,3 @@
 module BingAdsReporting
-  VERSION = '4.2.0'.freeze
+  VERSION = '5.0.0'.freeze
 end