tinystdio: Add a fix for rounding in case of 0 decimal places for fmode #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this change, in case of rouding to 0 decimal places with fmode for 0 < x < 1 some numbers get printed incorrectly such as 0,45 gets rounded to 1 instead of 0 it's because rounding happens in dtoa_ryu.c d2d function then another rounding happens in vfprintf function itself, because that cascading rounding results in incorrect results incase of rounding to 0 decimal places, this change prevents the extra rounding that happens in dtoa_ryu.c and rely on vfprintf rounding for this case. Signed-off-by: Ahmed Shehab <[email protected]>
Signed-off-by: Ahmed Shehab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this change, in case of rouding to 0 decimal places with fmode for 0 < x < 1
some numbers get printed incorrectly such as 0,45 gets rounded to 1 instead of 0
it's because rounding happens in dtoa_ryu.c d2d function then another rounding
happens in vfprintf function itself, because that cascading rounding results in
incorrect results incase of rounding to 0 decimal places, this change prevents
the extra rounding that happens in dtoa_ryu.c and rely on vfprintf rounding for
this case.