Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 30 day staleness limit restriction for integration scanning #141

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

JeffreyHuynh1
Copy link
Contributor

@JeffreyHuynh1 JeffreyHuynh1 commented Nov 9, 2023

Overview

Broker has a 30 day staleness limit on git commits. This has caused frustrations for Mars as they have many repos that they want to import to Broker which are not frequently updated (last commit > 30 days). As a result, we want to remove this staleness limit.

Acceptance criteria

Remove staleness limit and ensure that repo can scan repos with git commits > 30 days

Changes will need to made to this function

The staleness limit is defined by this const variable

Testing plan

Manually test changes against repos with branches / tags with their last change being > 30 days.

Repos Tested Against:

Risks

References

Add links to any referenced GitHub issues, Zendesk tickets, Jira tickets, Slack threads, etc.

Example:

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).

@JeffreyHuynh1 JeffreyHuynh1 requested a review from a team as a code owner November 9, 2023 21:17
@JeffreyHuynh1 JeffreyHuynh1 requested a review from spatten November 9, 2023 21:17
Copy link
Member

@jssblck jssblck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after doc updates.

docs/reference/faq.md Outdated Show resolved Hide resolved
docs/reference/faq.md Outdated Show resolved Hide resolved
src/api/remote.rs Outdated Show resolved Hide resolved
src/api/remote/git/repository.rs Outdated Show resolved Hide resolved
src/ext/command.rs Outdated Show resolved Hide resolved
src/ext/command.rs Outdated Show resolved Hide resolved
@JeffreyHuynh1 JeffreyHuynh1 merged commit f4d31e9 into main Nov 13, 2023
12 checks passed
@JeffreyHuynh1 JeffreyHuynh1 deleted the ANE-1278-30-day-staleness branch November 13, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants