Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limitation to pipenv.md #1369

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions docs/references/strategies/languages/python/pipenv.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ dependencies. This will fail unless `pipenv install` has been run in that direct

## Limitations

- Pipfile.lock does not report edges, if `pipenv graph --json-tree` fails, we will
not be able to detect the edges between dependencies.
- This strategy does not report edges between dependencies. This means that all dependencies being used in the project are found, but are all reported as direct dependencies of the project.

- `pipenv graph --json-tree` relies on `pipenv install` being run in the directory beforehand.
If that command was not run (such as in a freshly cloned repo), then the graph command will fail,
Expand Down
2 changes: 1 addition & 1 deletion docs/references/strategies/languages/python/python.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ The python buildtool ecosystem consists of three major toolchains: setuptools

| Strategy | Direct Deps | Transitive Deps | Edges | Container Scanning |
| ---------------------------------------------- | ------------------ | ------------------ | ------------------ | ------------------ |
| [pipenv](pipenv.md) | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | :x: |
| [pipenv](pipenv.md) | :heavy_check_mark: | :heavy_check_mark: | :x: | :x: |
| [pipfile](pipenv.md) | :heavy_check_mark: | :heavy_check_mark: | :x: | :x: |
| [requirements.txt & setuptools](setuptools.md) | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | :heavy_check_mark: |
| [setup.py & setuptools](setuptools.md) | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | :heavy_check_mark: |
Expand Down
Loading